fix: create app shows dest URL instead of name

[rbreeze]

Fixes #11228

Signed-off-by: Remington Breeze remington@breeze.software

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Base: 47.44% // Head: 47.44% // No change to project coverage 👍

Coverage data is based on head (d60b0a1) compared to base (c20301f).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #12054   +/-   ##
=======================================
  Coverage   47.44%   47.44%           
=======================================
  Files         245      245           
  Lines       41690    41690           
=======================================
  Hits        19778    19778           
  Misses      19925    19925           
  Partials     1987     1987           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[keithchong]

LGTM

[gomgomshrimp]

@rbreeze

Hi, I am currently checking for a problem in argocd v2.7.6 where it is not possible to select the name of the destination in the application creation panel. #13655

While doing so, I found this PR and issue #11228

Doesn't this PR affect the issue of not being able to select the name of the destination?
This was working in previous versions. Below is a video of the issue.

record-2023-07-03.15.05.47.mov

[slammajamma28]

I am seeing the same issue as @gomgomshrimp where we cannot select Name as a destination in the dropdown running v2.7.6.

Will this PR correct that? I noticed there are a couple of other open issues referencing this - #13813 and #13655

[gomgomshrimp]

@slammajamma28
This PR disables the name dropdown for the destination.

Because this PR is the only one that changes the destination dropdown, and I actually found that it work when I removed the code and tested it.

I was going to create a PR to fix it, but there is already in progress that fixes this issue. Please see the following. (#14216)