fix(ui): update ui e2e tests#14619
Conversation
Signed-off-by: ebuildy <tdecaux@petalmd.com>
|
I was actually thinking a unit test like this. Didn't even realize we had selenium tests. But this is awesome too. :-D |
keithchong
left a comment
keithchong
left a comment
There was a problem hiding this comment.
@ebuildy , LGTM. Sorry about the long delay. Could you rebase this? I'll merge this right away after the CI checks are green.
| @@ -1,11 +1,14 @@ | |||
| require('dotenv').config({path: __dirname + '/.env'}); | |||
| require('dotenv').config({path: __dirname + '/../.env'}); | |||
There was a problem hiding this comment.
If we run the scripts defined in the package.json, the .env file gets copied over to the out folder and so it will be in current directory. But this will work too.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14619 +/- ##
==========================================
- Coverage 55.07% 55.02% -0.05%
==========================================
Files 324 324
Lines 55466 55466
==========================================
- Hits 30547 30521 -26
- Misses 22303 22328 +25
- Partials 2616 2617 +1 ☔ View full report in Codecov by Sentry. |
|
Thanks @ebuildy |
Signed-off-by: ebuildy <tdecaux@petalmd.com>
Signed-off-by: ebuildy <tdecaux@petalmd.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Signed-off-by: ebuildy <tdecaux@petalmd.com>
3 participants
From my PR about UI #14376 , @crenshaw-dev asked me to add an ui e2e test.
I found it broken because UI code have changed (className etc...), so I wrote this PR to make ui e2e test work.
Need #14216 to work.
Changes:
ARGOCD_NAMESPACEconfig, because app name now is prefixed by app definition namespace(btw I was very happy to meet selenium again!)