fix: UI: Nothing happens selecting cluster URL/Name dropdown (#13655)#21028
Merged
ishitasequeira merged 1 commit intoargoproj:masterfrom Dec 4, 2024
Merged
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
…j#13655) Signed-off-by: Keith Chong <kykchong@redhat.com>
028274e to
afa31f2
Compare
andrii-korotkov-verkada
approved these changes
Dec 3, 2024
Contributor
|
LGTM! |
adriananeci
pushed a commit
to adriananeci/argo-cd
that referenced
this pull request
Dec 4, 2024
…j#13655) (argoproj#21028) Signed-off-by: Keith Chong <kykchong@redhat.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
revitalbarletz
pushed a commit
to revitalbarletz/argo-cd
that referenced
this pull request
Jan 20, 2025
…j#13655) (argoproj#21028) Signed-off-by: Keith Chong <kykchong@redhat.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13655
There are actually multiple issues that this PR will try to address.
There are several test scenarios affected by this.
serverandnameserverandnameserverandnameNote:
serverandnamein the interfaceApplicationDestinationin models.ts should be made optional, but for the purposes of this PR, I just changed the initial value to beundefined, and then later on in the logic, one of these would be set to the empty string. (This explains that code change).Previous Issues and PRs related to this.
#13813
#14216
and
#11228
#12054
Checklist: