add pass_credentials to helm source #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onematchfox
requested changes
May 4, 2023
There was a problem hiding this comment.
Hi @duncan485,
Thanks for this! The changes look great.
To answer your comment - no schema updates are needed in this case, so you're all good.
One small ask from my side... Could you please add this new field (pass_credentials = true) to the existing test for Helm charts here?
Annoying as hell that this isn't consistently applied across the codebase... (and conflicts with go fmt)... not your bad.
duncan485
commented
May 4, 2023
| @@ -1127,7 +1127,7 @@ resource "argocd_application" "helm" { | |||
| value = "standalone" | |||
| } | |||
|
|
|||
| pass_credentials = true | |||
| pass_credentials = true | |||
There was a problem hiding this comment.
Was already a bit confused, thanks for the quick fix 😄
onematchfox
approved these changes
May 4, 2023
|
@duncan485, thanks again! This will be released along with the next version - currently targeting early next week, pending review on #268/#273 as well as my availability due to some upcoming travel. If you need it released sooner, then let me know, and I'll do my best to help out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #269