Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pass_credentials in helm #269

Closed
jcogilvie opened this issue Apr 27, 2023 · 2 comments · Fixed by #271
Closed

Add support for pass_credentials in helm #269

jcogilvie opened this issue Apr 27, 2023 · 2 comments · Fixed by #271
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Community help wanted!

Comments

@jcogilvie
Copy link

jcogilvie commented Apr 27, 2023

Description

Helm sometimes requires the pass_credentials flag to be set on the argocd_application. The provider should support this.

Potential Terraform Configuration

  spec {
    destination {
      server = "https://kubernetes.default.svc"
    }

    source {
      helm {
        release_name = local.service_name
        values       = local.helm_values
        pass_credentials = true
      }
    }
  }

References

https://argo-cd.readthedocs.io/en/stable/user-guide/helm/#helm-pass-credentials

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@jcogilvie jcogilvie added the enhancement New feature or request label Apr 27, 2023
@onematchfox onematchfox added help wanted Community help wanted! good first issue Good for newcomers labels Apr 27, 2023
@duncan485
Copy link
Contributor

duncan485 commented May 3, 2023

I'm a bit new to writing terraform providers, but I'd like to give this one a try.

@duncan485
Copy link
Contributor

duncan485 commented May 3, 2023

Hey @onematchfox I've created #271 . I wasn't sure whether I should introduce a new schema version for this change. But I've tested the provider locally and it is functional like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Community help wanted!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants