Fix crash on 2.7.x due to use of List to read applications
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onematchfox
changed the title
List to read applications2.7.x due to use of List to read applications
onematchfox
force-pushed
the
fix/application
branch
from
a711f72 to
f753e77
Compare
onematchfox
force-pushed
the
fix/application
branch
from
f753e77 to
477d2aa
Compare
onematchfox
force-pushed
the
fix/application
branch
from
f56d254 to
fc856eb
Compare
|
Note: had to re-work some of the tests as these were constantly failing with the latest version. Can't quite explain the behaviour though. |
oboukili
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API has changed to returning a blank list rather than
NotFoundwhen using theListendpoint to retrieve applications. This exposed flaws in the logic (introduced in #254) related to the checking how many items were returned in theApplicationList. This PR addresses those flaws.Closes #272