Enhanced/improved provider configuration options and documentation #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were available on the provider configuration but not actually used,
These cannot be used by the provider so there's no point in having them here.
This does not need to be supplied when port forwarding or using local config.
oboukili
requested changes
Apr 27, 2023
docs/index.md
Outdated
| # context = "foo" # Use explicit context from ArgoCD config instead of `current-context`. | ||
| } | ||
|
|
||
| # Unexposed ArgoCD API - using port-forwarding to temporarily expose ArgoCD API |
There was a problem hiding this comment.
Suggested change
| # Unexposed ArgoCD API - using port-forwarding to temporarily expose ArgoCD API | |
| # Unexposed ArgoCD API - using the current Kubernetes context and port-forwarding to temporarily expose ArgoCD API |
Co-authored-by: Olivier Boukili <[email protected]>
onematchfox
force-pushed
the
feat/provider-config
branch
from
35b5944 to
95d07b4
Compare
|
@oboukili, quick reminder that I'm waiting on a final review here. |
oboukili
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that lots of folks struggle with how to configure the provider, so I decided to try better understand the various configuration options myself and improve the documentation around this.
In doing so, I spotted a number of configuration options on the
kubernetesblock that were never used. So, I implemented those that could be implemented and removed those that could not be implemented.Additionally, while delving through the argocd CLI code, I found that we can actually implement support for ArgoCD core, albeit with some restrictions/quid-pro-quos (as documented).
The outcome of all of this is, hopefully, far better documentation on the ways in which the provider can be configured (alongside examples of the varying options).
Closes #267
Closes #202
Closes #170
Partial resolution of #135