Skip to content

Hack i18n_robot_pull paver command + updated translations - #393

Merged
OmarIthawi merged 4 commits into
appsembler/tahoe/developfrom
omar/update-lang-files
Jun 14, 2019
Merged

Hack i18n_robot_pull paver command + updated translations#393
OmarIthawi merged 4 commits into
appsembler/tahoe/developfrom
omar/update-lang-files

Conversation

@OmarIthawi

@OmarIthawi OmarIthawi commented May 31, 2019

Copy link
Copy Markdown

So, this one definitely needs a staging deployment first. I'm still not sure if it'll work well.

Summary

@OmarIthawi
OmarIthawi requested review from melvinsoft and thraxil May 31, 2019 15:18
@OmarIthawi

Copy link
Copy Markdown
Author

@OmarIthawi

Copy link
Copy Markdown
Author

thraxil
thraxil previously approved these changes Jun 1, 2019
Comment thread pavelib/i18n.py Outdated
@OmarIthawi
OmarIthawi force-pushed the omar/update-lang-files branch 2 times, most recently from 7ebed67 to 2148811 Compare June 10, 2019 10:08
@OmarIthawi
OmarIthawi force-pushed the omar/update-lang-files branch from 2148811 to ee39dd2 Compare June 10, 2019 10:09
@OmarIthawi
OmarIthawi requested review from melvinsoft and thraxil and removed request for melvinsoft June 10, 2019 10:13
@OmarIthawi
OmarIthawi changed the base branch from appsembler/tahoe/master to appsembler/tahoe/develop June 10, 2019 13:38
@OmarIthawi

Copy link
Copy Markdown
Author

@melvinsoft @thraxil this addresses the issues in #395 and #380 . Please take another look.

@thraxil thraxil left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same tweak as before.

Comment thread pavelib/i18n.py Outdated
Co-Authored-By: Anders Pearson <anders@thraxil.org>
@OmarIthawi
OmarIthawi merged commit f6df544 into appsembler/tahoe/develop Jun 14, 2019
@OmarIthawi OmarIthawi changed the title New i18n_release_pull_and_compile paver command + updated translations Hack i18n_robot_pull paver command + updated translations Jun 14, 2019
@OmarIthawi
OmarIthawi deleted the omar/update-lang-files branch November 21, 2019 07:39
OmarIthawi added a commit that referenced this pull request Apr 7, 2021
The hack was introduced in both:

 - #393 , and
 - #380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants