Update i18n translation from Transifex (first time on Juniper) - #872
Merged
Conversation
without this fix i18n_robot_pull would only pull reviewed entries which is a problem since release translations are not reviewed: - openedx/i18n-tools#96
OmarIthawi
force-pushed
the
omar/i18n-apr-7
branch
from
April 7, 2021 17:07
a636311 to
d18b056
Compare
OmarIthawi
commented
Apr 7, 2021
| django.pluralidx = function(n) { | ||
| var v=n==0 ? 0 : n==1 ? 1 : n==2 ? 2 : n%100>=3 && n%100<=10 ? 3 : n%100>=11 && n%100<=99 ? 4 : 5; | ||
| if (typeof(v) == 'boolean') { | ||
| return v ? 1 : 0; | ||
| } else { | ||
| return v; | ||
| } | ||
| }; | ||
| django.pluralidx = function(count) { return (count == 1) ? 0 : 1; }; |
Author
There was a problem hiding this comment.
This change would break the Arabic plural forms, but I don't want to fix it now. We don't use Arabic and I don't know what's causing Django to switch to this oversimplified plural form.
OmarIthawi
marked this pull request as ready for review
April 7, 2021 17:13
thraxil
approved these changes
Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RED-1509. This addressed my reported
juniper_i18nQA issues due to the outdated translations of Juniper.This a regular process in every release upgrade. Unfortunately, we usually have to do hacks and workarounds over the standard Open edX process since it's not much tailored to our needs as fork maintainers.
Changes
edx-i18n-toolshack that was introduced in Hacki18n_robot_pullpaver command + updated translations #393raw_input->inputtahoe_i18n_transifex_release_pullpaver task to as a stopgap for the issue Feature: Allow pulling unreviewed entries when running$ i18n_tool transifex pullopenedx/i18n-tools#96Runbook
Tests
This pull request has no tests for thew paver tasks. Those tasks would be very hard to test against and we run them on engineer machines so they're safer to keep untested.
Testing is still possible, but out of the scope of this upgrade since we'd like to focus on code that's being used by customers instead.
How to review this pull request?
It's very hard to review this pull request but few things to keep any eye on:
.pofiles.