Revert translation updates to get back old Canadian French translations - #417
Merged
Conversation
|
@OmarIthawi What mistake do you think you made? I'm not familiar enough with i18n in Django/Open edX to really voice an opinion. If you think you need to revert and I have a vote, I vote that you revert and fix what you need |
Author
Author
|
Good question @johnbaldwin! I've added more description above. |
iamjazzar
approved these changes
Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a mistake in #399 and #393. I'm reverting those translations back, until we fix them.
Description
In #393 I switched to use the Open edX release translations instead of the using the latest ones. This makes sense to avoid loosing translations as edX updates their master.
However, I didn't know that the release files had no translations or the translations are not reviewed.
I trusted the pull process without verifying the result. Partly because it used to work so well for me in the past. Not verifying was the mistake.
PSAC reported the issue in more than one channel of communication.
This pull request reverts the translations to what it was before #393, even though it keeps the scripts as is.
Next step is to find a solution for the issue and fix it in both of the Open edX Transifex and the scripts.
More details in the Trello Card: