Revert "Prep to update the Tahoe languages" - #395
Merged
Conversation
appsembler-mirror
approved these changes
Jun 7, 2019
thraxil
approved these changes
Jun 7, 2019
thraxil
left a comment
thraxil
left a comment
There was a problem hiding this comment.
from the exception, we could probably get away with just backing off edx-i18n-tools. but let's fix it first and investigate later.
Author
|
Agreed, thanks @thraxil |
|
😒 If you keep |
Author
|
@OmarIthawi Agh, sorry to hear that. Is this a requirements in order to upgrade our translations? |
|
Yes @melvinsoft, otherwise it's almost impossible to update the translations. I've addressed it in a better way on #393 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #380
@OmarIthawi The previous PR broke Studio due to a version conflict, I'm reverting it until you get back and we can see it with more detail.