Merged
Conversation
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 79 new, 34 changed, 31 removedBuild ID: 46ab82a2cf633f17a9cbe82e URL: https://www.apollographql.com/docs/deploy-preview/46ab82a2cf633f17a9cbe82e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Features
jemalloc metrics (PR #7735)
The router adds the following new metrics when running the router on Linux with its default
global-allocatorfeature:apollo_router_jemalloc_active: Total number of bytes in active pages allocated by the application.apollo_router_jemalloc_allocated: Total number of bytes allocated by the application.apollo_router_jemalloc_mapped: Total number of bytes in active extents mapped by the allocator.apollo_router_jemalloc_metadata: Total number of bytes dedicated to metadata, which comprise base allocations used for bootstrap-sensitive allocator metadata structures and internal allocations.apollo_router_jemalloc_resident: Maximum number of bytes in physically resident data pages mapped by the allocator, comprising all pages dedicated to allocator metadata, pages backing active allocations, and unused dirty pages.apollo_router_jemalloc_retained: Total number of bytes in virtual memory mappings that were retained rather than being returned to the operating system via e.g.munmap(2)or similar.By @Velfi in #7735
🐛 Fixes
Query planning errors with progressive override on interface implementations (PR #7929)
The router now correctly generates query plans when using progressive override (
@overridewith labels) on types that implement interfaces within the same subgraph.Previously, the Rust query planner would fail to generate plans for these scenarios with the error
"Was not able to find any options for {}: This shouldn't have happened.", while the JavaScript planner handled them correctly.This fix resolves planning failures when your schema uses:
These will now successfully plan and execute.
By @TylerBloom in #7929
WebSocket connection cleanup for subscriptions (PR #8104)
WebSocket connections to subgraphs now close properly when all client subscriptions end, preventing unnecessary resource usage.
Previously, connections could remain open after clients disconnected, not being cleaned up until a new event was received. The router now tracks active subscriptions and closes the subgraph connection when the last client disconnects, ensuring efficient resource management.
By @bnjjj in #8104
Reduce log level for interrupted WebSocket streams (PR #8344)
The router now logs interrupted WebSocket streams at
tracelevel instead oferrorlevel.Previously, WebSocket stream interruptions logged at
errorlevel, creating excessive noise in logs when clients disconnected normally or networks experienced transient issues. Client disconnections and network interruptions are expected operational events that don't require immediate attention.Your logs will now be cleaner and more actionable, making genuine errors easier to spot. You can enable
tracelevel logging when debugging WebSocket connection issues.By @bnjjj in #8344
Connection shutdown race condition during hot reload (PR #8169)
The router now reliably terminates all connections during hot reload, preventing out-of-memory errors from multiple active pipelines.
A race condition during hot reload occasionally left connections in an active state instead of terminating. Connections that are opening during shutdown now immediately terminate, maintaining stable memory usage through hot reloads.
By @BrynCooke in #8169