Merged
Conversation
This comment has been minimized.
This comment has been minimized.
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 7 changed, 1 removedBuild ID: aa3f98dd98ae5cd6872aa81c URL: https://www.apollographql.com/docs/deploy-preview/aa3f98dd98ae5cd6872aa81c |
6633373 to
6f52726
Compare
garypen
reviewed
Jun 25, 2025
Contributor
garypen
left a comment
There was a problem hiding this comment.
Looks great. I've made a suggestion about trying to leverage the jemalloc stats cache.
Co-authored-by: Gary Pennington <gary@apollographql.com>
garypen
reviewed
Jun 26, 2025
Contributor
garypen
left a comment
There was a problem hiding this comment.
One small fix so it can compile.
I made the fix on my laptop and then tested in a linux VM (that was a whole thing...) and found the integration test failed. Extract from fail:
thread 'integration::metrics::test_jemalloc_metrics_are_emitted' panicked at apollo-router/tests/integration/../common.rs:988:9:
'apollo_router_jemalloc_active' not detected in metrics
# HELP apollo_router_cache_miss_time Time to check the cache for an uncached value in seconds
So, it looks like there's an issue with the creation of the metric.
Sorry Zelda. I misled you. You have to create the gauge outside of the layer and then reference the gauge from the layer. With these small changes, things are working.
We can't build on windows with jemalloc-ctl as a dependency. So, let's try to only have these dependencies on linux.
garypen
approved these changes
Jun 27, 2025
Contributor
|
@mergify.io backport 1.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following new metrics when running Linux with the
global-allocatorfeature:munmap(2)or similar.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩