Merged
Conversation
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 98c7f423a5d7bddf9e95bcf7 |
Contributor
|
@TylerBloom, please consider creating a changeset entry in |
duckki
approved these changes
Jul 18, 2025
Contributor
duckki
left a comment
duckki
left a comment
There was a problem hiding this comment.
Looks good!
I've already reviewed the previous incarnation of this PR.
Contributor
|
Once merged. let's backport this to 1.x. |
TylerBloom
force-pushed
the
tylerb/fed-644
branch
from
d109c4f to
25baf46
Compare
10 tasks
7 tasks
10 tasks
TylerBloom
added a commit
that referenced
this pull request
Jul 28, 2025
TylerBloom
added a commit
that referenced
this pull request
Jul 28, 2025
(cherry picked from commit c7c334d)
TylerBloom
added a commit
that referenced
this pull request
Jul 28, 2025
TylerBloom
added a commit
that referenced
this pull request
Jul 28, 2025
abernix
added a commit
that referenced
this pull request
Jul 28, 2025
10 tasks
TylerBloom
added a commit
that referenced
this pull request
Jul 28, 2025
10 tasks
TylerBloom
added a commit
that referenced
this pull request
Jul 28, 2025
abernix
added a commit
that referenced
this pull request
Jul 28, 2025
TylerBloom
added a commit
that referenced
this pull request
Jul 28, 2025
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue from the porting of the query planner. Some edges in the query graph were being incorrectly treated as external. This caused them to be removed from the query graph and for building a plan to fail.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩