Skip to content

fix(subscription): do not log an error when the websocket stream has been interrupted, keep it in trace level to avoid useless noises#8344

Merged
bnjjj merged 2 commits intodevfrom
bnjjj/fix_error_log_subs
Oct 7, 2025
Merged

fix(subscription): do not log an error when the websocket stream has been interrupted, keep it in trace level to avoid useless noises#8344
bnjjj merged 2 commits intodevfrom
bnjjj/fix_error_log_subs

Conversation

@bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Sep 26, 2025

Convert log from error level to trace when the websocket stream has been interrupted to avoid useless noises.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

…been interrupted, keep it in trace level to avoid useless noises

Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from a team September 26, 2025 14:36
@apollo-librarian
Copy link

apollo-librarian bot commented Sep 26, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 0f4fd3d6d55de1726cad8fae
Build Logs: View logs

@github-actions

This comment has been minimized.

Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from a team as a code owner September 26, 2025 14:37
@bnjjj bnjjj added the backport-1.x Backport this PR to 1.x label Sep 26, 2025
@bnjjj bnjjj requested a review from goto-bus-stop September 29, 2025 08:59
@bnjjj bnjjj merged commit b0a1e90 into dev Oct 7, 2025
15 checks passed
@bnjjj bnjjj deleted the bnjjj/fix_error_log_subs branch October 7, 2025 21:12
bnjjj added a commit that referenced this pull request Oct 7, 2025
…been interrupted, keep it in trace level to avoid useless noises (#8344)

Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
(cherry picked from commit b0a1e90)
bnjjj added a commit that referenced this pull request Oct 8, 2025
…been interrupted, keep it in trace level to avoid useless noises (backport #8344) (#8383)
This was referenced Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-1.x Backport this PR to 1.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants