Fixed FED 644

[TylerBloom]

This PR addresses an issue from the porting of the query planner. Some edges in the query graph were being incorrectly treated as external. This caused them to be removed from the query graph and for building a plan to fail.

---

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

• PR description explains the motivation for the change and relevant context for reviewing
• PR description links appropriate GitHub/Jira tickets (creating when necessary)
• Changeset is included for user-facing changes
• Changes are compatible¹
• Documentation² completed
• Performance impact assessed and acceptable
• Metrics and logs are added³ and documented
• Tests added and passing⁴
  • Unit tests
  • Integration tests
  • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩

2. Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩

3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices. ↩

4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩

[github-actions]

@TylerBloom, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

[apollo-librarian]

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: dc733b3b83c9f45659222997

[TylerBloom]

This is not an error, but a difference between how JS and Rust represent paths.

[TylerBloom]

This is the source of the issue. See the corresponding JS code.

[duckki]

Looks good!
Have you tried it over the corpus?

[TylerBloom]

@duckki , I just completed a run through corpus and it seems like it introduced 260 correctness errors 🙈

[TylerBloom]

Correction! I was reading the data incorrectly. Of the data in corpus, there are no regressions (or improvements) in correctness.