Skip to content

test(federation): updated Display for GraphPath to show multiple conditions#7937

Merged
duckki merged 1 commit intodevfrom
duckki/graph-path-conditions-display
Jul 21, 2025
Merged

test(federation): updated Display for GraphPath to show multiple conditions#7937
duckki merged 1 commit intodevfrom
duckki/graph-path-conditions-display

Conversation

@duckki
Copy link
Contributor

@duckki duckki commented Jul 19, 2025

In order to match JS implementation (github) more closely.

  • I noticed a discrepancy in the GraphPath printing code compared to the JS version.
  • But, then I realized QueryGraphEdge::fmt is doing the right thing, already.

A follow-up of PR #7929.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added[^3] and documented
  • Tests added and passing[^4]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

This PR is only for debug messages. No behavioral changes.

@github-actions
Copy link
Contributor

@duckki, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@apollo-librarian
Copy link

apollo-librarian bot commented Jul 19, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 6 changed, 0 removed
* (developer-tools)/apollo-server/(latest)/getting-started.mdx
* (developer-tools)/apollo-server/(latest)/data/subscriptions.mdx
* (developer-tools)/apollo-server/(latest)/integrations/mern.mdx
* (developer-tools)/apollo-server/(latest)/schema/directives.md
* (developer-tools)/apollo-server/(latest)/testing/testing.mdx
* (developer-tools)/apollo-server/(latest)/workflow/generate-types.mdx

Build ID: 23ed1ed35ff7b809d87250f7

URL: https://www.apollographql.com/docs/deploy-preview/23ed1ed35ff7b809d87250f7

@duckki duckki force-pushed the duckki/graph-path-conditions-display branch from 8e91457 to 0b30761 Compare July 19, 2025 01:23
@duckki duckki marked this pull request as ready for review July 19, 2025 01:29
@duckki duckki requested review from a team as code owners July 19, 2025 01:29
@duckki duckki merged commit 15348d0 into dev Jul 21, 2025
15 checks passed
@duckki duckki deleted the duckki/graph-path-conditions-display branch July 21, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants