Skip to content

Turns out you can't create the gauges in the layer fn#7778

Merged
Velfi merged 2 commits intozelda-jemalloc-metricsfrom
garypen/more-jemalloc
Jun 27, 2025
Merged

Turns out you can't create the gauges in the layer fn#7778
Velfi merged 2 commits intozelda-jemalloc-metricsfrom
garypen/more-jemalloc

Conversation

@garypen
Copy link
Contributor

@garypen garypen commented Jun 27, 2025

Sorry Zelda. I misled you. You have to create the gauge outside of the layer and then reference the gauge from the layer.

With these small changes, things are working.

Sorry Zelda. I misled you. You have to create the gauge outside of the
layer and then reference the gauge from the layer.

With these small changes, things are working.
@garypen garypen requested a review from a team June 27, 2025 08:14
We can't build on windows with jemalloc-ctl as a dependency.

So, let's try to only have these dependencies on linux.
@apollo-librarian
Copy link

apollo-librarian bot commented Jun 27, 2025

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch zelda-jemalloc-metrics is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

  • !docs set-base-branch 1.x
  • !docs set-base-branch dev

Build ID: 9a6a9298fa3957aaba4cf347

@garypen garypen self-assigned this Jun 27, 2025
@garypen garypen requested a review from Velfi June 27, 2025 10:48
@Velfi Velfi merged commit 8c68037 into zelda-jemalloc-metrics Jun 27, 2025
14 checks passed
@Velfi Velfi deleted the garypen/more-jemalloc branch June 27, 2025 13:17
@garypen garypen removed their assignment Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants