Skip to content

Backport: #7735 Jemalloc metrics#8032

Merged
BrynCooke merged 1 commit into1.xfrom
bryn/jemalloc-metrics-backport
Aug 1, 2025
Merged

Backport: #7735 Jemalloc metrics#8032
BrynCooke merged 1 commit into1.xfrom
bryn/jemalloc-metrics-backport

Conversation

@BrynCooke
Copy link
Contributor

@BrynCooke BrynCooke commented Aug 1, 2025

This PR backports #7735

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@apollo-librarian
Copy link

apollo-librarian bot commented Aug 1, 2025

❌ Docs preview failed

The preview failed to build.

Build ID: c309adb7e6ced6b7f14311ae
Build Logs: View logs

Errors

General: Error parsing (developer-tools)/apollo-operator/_sidebar.yaml: [
{
"code": "unrecognized_keys",
"keys": [
"children"
],
"path": [
"items",
0
],
"message": "Unrecognized key(s) in object: 'children'"
},
{
"code": "unrecognized_keys",
"keys": [
"children"
],
"path": [
"items",
1,
"children",
0
],
"message": "Unrecognized key(s) in object: 'children'"
},
{
"code": "unrecognized_keys",
"keys": [
"children"
],
"path": [
"items",
3
],
"message": "Unrecognized key(s) in object: 'children'"
}
]

@BrynCooke BrynCooke changed the base branch from dev to 1.x August 1, 2025 11:37
@BrynCooke BrynCooke force-pushed the bryn/jemalloc-metrics-backport branch from 04261e5 to 1f802cc Compare August 1, 2025 12:10
@BrynCooke BrynCooke marked this pull request as ready for review August 1, 2025 12:10
@BrynCooke BrynCooke requested a review from a team August 1, 2025 12:10
@BrynCooke BrynCooke requested review from a team as code owners August 1, 2025 12:10
@BrynCooke BrynCooke merged commit 6b28926 into 1.x Aug 1, 2025
12 of 14 checks passed
@BrynCooke BrynCooke deleted the bryn/jemalloc-metrics-backport branch August 1, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants