Skip to content

Conversation

@bustios
Copy link
Contributor

@bustios bustios commented Aug 2, 2016

What is this PR for?

Bug fix in z.show() for matplotlib graphs and code refactoring

What type of PR is it?

Bug Fix

What is the Jira issue?

ZEPPELIN-1261

How should this be tested?

%python
import matplotlib.pyplot as plt

x = [1,2,3,4,5]
y = [6,7,8,9,0]

plt.plot(x, y, marker="o")
z.show(plt, height="20em")
plt.close()
%python
import matplotlib.pyplot as plt

x = [1,2,3,4,5]
y = [6,7,8,9,0]

plt.plot(x, y, marker="o")
z.show(plt, height="300px")
plt.close()

Screenshots (if appropriate)

z show height example

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@bzz
Copy link
Member

bzz commented Aug 3, 2016

Looks great to me, thank you @bustios !

Just FYI - in case of CI failure, If contributor posts failure logs from TravisCI, that helps to improve project stability a lot as it makes people fix flaky tests, infrastructural problems, etc.

Current CI failure is due to flaky ZeppelinSparkClusterTest.sparkRTest test:

[INFO] Zeppelin: Server ................................... FAILURE [03:05 min]
....
Results :

Failed tests: 
  ZeppelinSparkClusterTest.sparkRTest:116 expected:<[[1] 3]> but was:<[<pre><code>Error in getSparkSession(): SparkSession not initialized
</code></pre>

<pre><code>Error in (function (classes, fdef, mtable) : unable to find an inherited method for function 'count' for signature '&quot;function&quot;'
</code></pre>]>

Tests run: 65, Failures: 1, Errors: 0, Skipped: 0

same as #1249 #1051 #1160 #1043 #943 and #835. Logged under ZEPPELIN-1271

Merging to master if there is no further discussion

@bustios
Copy link
Contributor Author

bustios commented Aug 3, 2016

I see. Thanks for your help and information @bzz. I'll keep it in mind for subsequent PRs

@bzz
Copy link
Member

bzz commented Aug 3, 2016

Sounds great! Apparently CI failure has been addressed in #1259 as well

@asfgit asfgit closed this in 9eac20d Aug 3, 2016
PhilippGrulich pushed a commit to SWC-SENSE/zeppelin that referenced this pull request Aug 8, 2016
### What is this PR for?
Bug fix in z.show() for matplotlib graphs and code refactoring

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-1261](https://issues.apache.org/jira/browse/ZEPPELIN-1261)

### How should this be tested?
```
%python
import matplotlib.pyplot as plt

x = [1,2,3,4,5]
y = [6,7,8,9,0]

plt.plot(x, y, marker="o")
z.show(plt, height="20em")
plt.close()
```
```
%python
import matplotlib.pyplot as plt

x = [1,2,3,4,5]
y = [6,7,8,9,0]

plt.plot(x, y, marker="o")
z.show(plt, height="300px")
plt.close()
```

### Screenshots (if appropriate)
![plot](https://dl.dropboxusercontent.com/u/20947972/z.show.height.example.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Paul Bustios <[email protected]>

Closes apache#1267 from bustios/ZEPPELIN-1261 and squashes the following commits:

82c631a [Paul Bustios] Add 100% as a default value for width and height z.show() parameters
3e0ef22 [Paul Bustios] Bug fix in show_matplotlib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants