[ZEPPELIN-905] Fix import notebook with error result #1043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swkimme @Leemoonsoo Ready for review |
Member
|
Looks good to me 2 CI failures seems un-related (not sure if it's been taken care of somewhere) 12 |
| newParagraph.setReturn(result, null); | ||
| } catch (Exception e) { | ||
| // 'result' part of Note consists of exception, instead of actual interpreter results | ||
| logger.warn("Paragraph " + srcParagraph.getId() + " has a result with exception. " |
Member
There was a problem hiding this comment.
Should this be a logger.error and re-throw the exception?
Member
Author
There was a problem hiding this comment.
In my understanding, if we re-throw error, import/clone notebook with Object result(for example String) other than InterpreterResult will fail as current master is.
Member
There was a problem hiding this comment.
@felixcheung good question, but I think this just happens to be an exception here and it does not represent an error condition in our logic, as it's fine for current notebook structure to have paragraph with an exception stack trace in the output.
Member
|
I think we should merge it ASAP as per ZEPPELIN-889 this blocks us from makeing a release. Any 👍 or 👎 ? |
Contributor
|
@bzz Let's merge this one 👍 |
Member
|
LGTM |
Member
Author
|
Merging it into master and branch-0.6 if there is no more discussion |
asfgit
pushed a commit
that referenced
this pull request
Jun 23, 2016
### What is this PR for? This PR is fixing import/clone notebook with error result. This PR adds test based on #933. > Note: This issue is one of the [blockers](https://issues.apache.org/jira/browse/ZEPPELIN-889) of 0.6.0 release so should be merged into branch-0.6 before release. ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-905](https://issues.apache.org/jira/browse/ZEPPELIN-905) ### How should this be tested? When you try to import or clone notebook with error result, it should work. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Kevin Kim <[email protected]> Author: Mina Lee <[email protected]> Closes #1043 from minahlee/ZEPPELIN-905 and squashes the following commits: 69b8c02 [Mina Lee] Add test for clone notebook with String type result e7af919 [Kevin Kim] stylish code 7bf5d01 [Kevin Kim] log info -> warn, add message d4f6699 [Kevin Kim] log exception 32949bc [Kevin Kim] trigger CI build 803e08a [Kevin Kim] revert implementation c13293f [Kevin Kim] fix test, better implementation 1e45a9e [Kevin Kim] [ZEPPELIN-905] add test a4188be [Kevin Kim] [ZEPPELIN-905] fix failed notebook import bug (cherry picked from commit 50db175) Signed-off-by: Mina Lee <[email protected]>
minahlee
added a commit
to minahlee/zeppelin
that referenced
this pull request
Jun 23, 2016
asfgit
pushed a commit
that referenced
this pull request
Jun 23, 2016
### What is this PR for? Hotfix for compile error of master, branch-0.6 after merging #1043 Author: Mina Lee <[email protected]> Closes #1070 from minahlee/hotfix/compile_error and squashes the following commits: b0d5a6b [Mina Lee] Fix compile error after merging #1043
asfgit
pushed a commit
that referenced
this pull request
Jun 23, 2016
### What is this PR for? Hotfix for compile error of master, branch-0.6 after merging #1043 Author: Mina Lee <[email protected]> Closes #1070 from minahlee/hotfix/compile_error and squashes the following commits: b0d5a6b [Mina Lee] Fix compile error after merging #1043 (cherry picked from commit 83602f5) Signed-off-by: Mina Lee <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jun 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR is fixing import/clone notebook with error result. This PR adds test based on #933.
What type of PR is it?
Bug Fix
What is the Jira issue?
ZEPPELIN-905
How should this be tested?
When you try to import or clone notebook with error result, it should work.
Questions: