[Zeppelin - 1152] Listing note revision history

[khalidhuseynov]

What is this PR for?

This PR addresses ability to view the history of note revisions from the version control menu

What type of PR is it?

Improvement

Todos

• - backend changes
• - tests
• - propagation to frontend
• - rendering list

What is the Jira issue?

Zeppelin - 1152

How should this be tested?

1. Select Git notebook storage layer as primary (e.g. in conf/zeppelin-env.sh add

export ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"

1. Select any note in Zeppelin and commit it in version control menu
2. The list with new commit should be shown in the same menu

Screenshots (if appropriate)

### Questions: - Does the licenses files need update? No - Is there breaking changes for older versions? No - Does this needs documentation? No

[corneadoug]

I made a dropdown for the revisions, so that it always show current one.
The caret button is only shown if there is some revisions.

Current dropdown format is: Date - Commit message

[corneadoug]

@khalidhuseynov All builds are red, can you check it out?

[khalidhuseynov]

@corneadoug thanks for the help with rendering list, and i've fixed the tests. CI is green and ready for review.

[Leemoonsoo]

Looks good. Can we display time as well as date in each revision?

[khalidhuseynov]

@Leemoonsoo updated code and screenshot with feedback

[corneadoug]

Is it better to have the Date potentially hidden or the title hidden?

[anthonycorbacho]

@khalidhuseynov what is the benefit of having a new websocket call? Why not use rest-api?

[khalidhuseynov]

@corneadoug i'm not sure exactly what you mean, could you provide an example?

@anthonycorbacho because:

• there're cases when backend will send the list triggered by different ws event (checkpoint) for example here
• to have consistency with original work and provide whole api through websocket, possibly later provide rest-api as well

[corneadoug]

@khalidhuseynov Previous order in the list was: Date - Title, now it is Title - Date.
As you can see in your screenshot, when the text gets too long, there is an ellipse:

add visualiz paragraph - July 19th 2016, 5...

[khalidhuseynov]

@corneadoug yeah i changed the order since it's more intuitive to have name first, and date afterwards. But you're right when too long name, the ellipse doesn't look good. how do you think we can fix it; maybe move date to new line, or any other suggestions?

[Leemoonsoo]

@corneadoug @khalidhuseynov

Or how about align commit message left, and align date right and use fixed length date format?
Then it gives little better readability i think.

add visualize paragrgraph...    2016-07-06 10:12:34
add tutorial                    2016-07-06 09:11:11
the first commit                2016-05-23 23:31:33

[khalidhuseynov]

okay, i'll play with it a bit then

[khalidhuseynov]

@corneadoug @Leemoonsoo @anthonycorbacho how about this one?

[corneadoug]

@khalidhuseynov looks good, but i would reduce the font size and spacing

[khalidhuseynov]

@corneadoug how about this one 614ed61 :

[bzz]

Great improvement! In this case WS protocol improvement makes sense indeed.

👍 for tests

CI is failing on

Results :

Failed tests: 
  ZeppelinSparkClusterTest.sparkRTest:104 expected:<FINISHED> but was:<ERROR>

Tests run: 65, Failures: 1, Errors: 0, Skipped: 0

which looks like a flaky test to me.

[khalidhuseynov]

addressed comments and CI is green. updated description screenshot as well, /cc @corneadoug @Leemoonsoo @bzz for review

[corneadoug]

LGTM

[bzz]

Looks good to me, merging if there is no further discussion