[ZEPPELIN-1260] R interpreter doesn't work with Spark 2.0 #1259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public ZeppelinR(String rCmdPath, String libPath, int sparkRBackendPort) { | ||
| public ZeppelinR(String rCmdPath, String libPath, | ||
| int sparkRBackendPort, SparkVersion sparkVersion) { |
Member
There was a problem hiding this comment.
This is a nitpick (so no need to change if you do not feel like it) but Is that IDE formatting?
As horizontal alignment is usually discouraged.
Member
|
Looks great to me, modulo question above. Thank you for prompt fix @Leemoonsoo ! |
Member
Author
|
@bzz Thanks for quick review. Updated the indent. |
Member
|
@minahlee Just saw you comment on ZEPPELIN-1260, but @Leemoonsoo has been fast... I have tested the changes, and now sparkr dataframes are working well (with the The R tutorial note refers to sqlContext which is no more present Patch could also expose sqlContext. |
Member
Author
|
Thanks @echarles for the review. I have exposed sqlContext as well |
Member
|
LGTM |
Member
Author
|
Merge it into master and branch-0.6 if there're no more discussion |
asfgit
pushed a commit
that referenced
this pull request
Aug 3, 2016
### What is this PR for? This PR fixes R interpreter doesn't work with Spark 2.0 ### What type of PR is it? Bug Fix ### Todos * [x] - Create and inject SparkSession into SparkRInterpreter ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1260 ### How should this be tested? Run Zeppelin with Spark 2.0 and run following codes and see if it returns `[1] 3` ``` %r localDF <- data.frame(name=c("a", "b", "c"), age=c(19, 23, 18)) df <- createDataFrame(spark, localDF) count(df) ``` ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes #1259 from Leemoonsoo/ZEPPELIN-1260 and squashes the following commits: b3df11f [Lee moon soo] inject sqlContext as well 02822ac [Lee moon soo] Change indent 6bd1128 [Lee moon soo] Create and inject spark session into sparkr interpreter (cherry picked from commit 52b3cbf) Signed-off-by: Mina Lee <[email protected]>
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? This PR fixes R interpreter doesn't work with Spark 2.0 ### What type of PR is it? Bug Fix ### Todos * [x] - Create and inject SparkSession into SparkRInterpreter ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1260 ### How should this be tested? Run Zeppelin with Spark 2.0 and run following codes and see if it returns `[1] 3` ``` %r localDF <- data.frame(name=c("a", "b", "c"), age=c(19, 23, 18)) df <- createDataFrame(spark, localDF) count(df) ``` ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Lee moon soo <[email protected]> Closes apache#1259 from Leemoonsoo/ZEPPELIN-1260 and squashes the following commits: b3df11f [Lee moon soo] inject sqlContext as well 02822ac [Lee moon soo] Change indent 6bd1128 [Lee moon soo] Create and inject spark session into sparkr interpreter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR fixes R interpreter doesn't work with Spark 2.0
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1260
How should this be tested?
Run Zeppelin with Spark 2.0 and run following codes and see if it returns
[1] 3Screenshots (if appropriate)
Questions: