chore: sql/parse cleanup

[betodealmeida]

SUMMARY

This PR removes the _sql attribute from SQLStatement and KustoKQLStatement, keeping only the AST in the class. This is important because in #33473 we modify the AST inplace, which would require calling format() to keep _sql in sync. Since the attribute is no longer used in any meaningful way it's better to just get rid of it.

Part of #26786, stacked on #33457, #33456, and #33473.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset/sql_lab.py	✅
superset/sql_parse.py	✅
superset/sql/parse.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[michael-s-molina]

Thanks for creating a feature branch for this @betodealmeida. It will help with testing.

[Vitor-Avila]

Is there a reason we're removing this? Is it redundant?

[betodealmeida]

Yeah, this is redundant. Before, to create a new statement we had to pass the SQL (a string) and the AST, so here we were generating the SQL. Now we just pass the AST directly.

[Vitor-Avila]

lgtm! did some manual testing as well and didn't notice any issues