Skip to content

chore: remove is_select_query#33457

Merged
betodealmeida merged 1 commit intomasterfrom
is-select-query-refactor
May 23, 2025
Merged

chore: remove is_select_query#33457
betodealmeida merged 1 commit intomasterfrom
is-select-query-refactor

Conversation

@betodealmeida
Copy link
Member

SUMMARY

Based on #33456.

More sqlparse removal for #26786.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset/db_engine_specs/kusto.py
superset/sql_lab.py
superset/db_engine_specs/base.py

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@betodealmeida betodealmeida force-pushed the is-select-query-refactor branch from 289aa25 to eb778b9 Compare May 15, 2025 21:28
@betodealmeida betodealmeida force-pushed the is-select-query-refactor branch 2 times, most recently from e7d1563 to 5cddcea Compare May 15, 2025 21:31
@betodealmeida betodealmeida force-pushed the is-select-query-refactor branch from 5cddcea to 6f904f2 Compare May 23, 2025 00:16
@pull-request-size pull-request-size bot added size/M and removed size/L labels May 23, 2025
@betodealmeida betodealmeida merged commit 8013b32 into master May 23, 2025
50 of 51 checks passed
@betodealmeida betodealmeida deleted the is-select-query-refactor branch May 23, 2025 00:53
LevisNgigi pushed a commit to LevisNgigi/superset that referenced this pull request Jun 18, 2025
@github-actions github-actions bot added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 6.0.0 First shipped in 6.0.0 labels Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 6.0.0 First shipped in 6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments