feat: implement CVAS/CTAS in sqlglot#33525
Merged
betodealmeida merged 1 commit intomasterfrom May 28, 2025
Merged
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Incorrect return value documentation ▹ view | 🧠 Not in standard |
|
Undocumented enum options ▹ view | 🧠 Not in scope |
Files scanned
| File Path | Reviewed |
|---|---|
| superset/sql/parse.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Comment on lines
+111
to
+113
| class CTASMethod(enum.Enum): | ||
| TABLE = enum.auto() | ||
| VIEW = enum.auto() |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
betodealmeida
force-pushed
the
sqlglot-ctas-cvas
branch
2 times, most recently
from
a133585 to
4af8cab
Compare
9 tasks
eschutho
approved these changes
May 28, 2025
betodealmeida
force-pushed
the
sqlglot-rls
branch
from
24bfe2b to
f1a8c98
Compare
betodealmeida
force-pushed
the
sqlglot-ctas-cvas
branch
from
4af8cab to
50ea702
Compare
This was referenced May 28, 2025
LevisNgigi
pushed a commit
to LevisNgigi/superset
that referenced
this pull request
Jun 18, 2025
github-actions
bot
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Part of #26786, stacked on:
Implements the
as_create_table,is_valid_cvas, andis_valid_ctasmethods insqlglot.Added unit tests from the
sqlparseimplementation.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION