feat: implement CTEs logic in sqlglot

[betodealmeida]

SUMMARY

Part of #26786, stacked on:

• chore: remove is_select_query #33457
• feat: implement limit extraction in sqlglot #33456
• feat: use sqlglot to set limit #33473
• chore: sql/parse cleanup #33515
• chore: remove parse_sql #33474.

Reimplements the allows_cte_in_subquery logic in sqlglot for SIP-117. This is used by MS SQL and Ocient when wrapping a query in the chart builder: if the original query has CTEs they need to be moved from the subquery to the top level of the query.

That is, this virtual dataset based off of MS SQL:

WITH foo AS (SELECT * FROM bar)
SELECT * FROM foo;

When used in a chart becomes:

WITH foo AS (SELECT * FROM bar),
     __cte AS (SELECT * FROM foo)
SELECT
  metric1(), metric2(), ...
  dim1, dim2, ...
  FROM __cte
GROUP BY dim1, dim2, ...

Note that in theory we could extract just the CTEs to the top-level, building this query:

WITH foo AS (SELECT * FROM bar)
SELECT
  metric1(), metric2(), ...
  dim1, dim2, ...
  FROM (SELECT * FROM foo)
GROUP BY dim1, dim2, ...

But since I don't have access to an MS SQL database I opted to preserve the existing behavior. If we ever decide to do that we could add a method split_ctes to SQLStatement which returns CTEs and the main query.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Missing CTE format validation ▹ view	🧠 Incorrect

Files scanned

​

File Path	Reviewed
superset/sql/parse.py	✅
superset/db_engine_specs/base.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X