[SPARK-41412][CONNECT][TESTS][FOLLOW-UP] Exclude binary casting to make the tests to pass with/without ANSI mode #39050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
HyukjinKwon
changed the title
HyukjinKwon
changed the title
Member
Author
|
Merged to master. |
Contributor
|
LGTM + 1 |
HyukjinKwon
added a commit
that referenced
this pull request
Dec 14, 2022
….sql.tests.connect.test_connect_column ### What changes were proposed in this pull request? This PR is a followup of #39047 which import `BinaryType` that's removed in #39050. This was a logical conflict. ### Why are the changes needed? To recover the build. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually verified by running `./dev/lint-python`. Closes #39055 from HyukjinKwon/SPARK-41506-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…ke the tests to pass with/without ANSI mode ### What changes were proposed in this pull request? This PR is another followup of apache#39034 that, instead, make the tests to pass with/without ANSI mode. ### Why are the changes needed? Spark Connect uses isolated Spark session so setting the configuration in PySpark side does not take an effect. Therefore, the test still fails, see https://github.com/apache/spark/actions/runs/3681383627/jobs/6228030132. We should make the tests pass with/without ANSI mode for now. ### Does this PR introduce _any_ user-facing change? No, test-only ### How was this patch tested? Manually tested via: ```bash SPARK_ANSI_SQL_MODE=true ./python/run-tests --testnames 'pyspark.sql.tests.connect.test_connect_column' ``` Closes apache#39050 from HyukjinKwon/SPARK-41412. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
….sql.tests.connect.test_connect_column ### What changes were proposed in this pull request? This PR is a followup of apache#39047 which import `BinaryType` that's removed in apache#39050. This was a logical conflict. ### Why are the changes needed? To recover the build. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually verified by running `./dev/lint-python`. Closes apache#39055 from HyukjinKwon/SPARK-41506-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is another followup of #39034 that, instead, make the tests to pass with/without ANSI mode.
Why are the changes needed?
Spark Connect uses isolated Spark session so setting the configuration in PySpark side does not take an effect. Therefore, the test still fails, see https://github.com/apache/spark/actions/runs/3681383627/jobs/6228030132.
We should make the tests pass with/without ANSI mode for now.
Does this PR introduce any user-facing change?
No, test-only
How was this patch tested?
Manually tested via:
SPARK_ANSI_SQL_MODE=true ./python/run-tests --testnames 'pyspark.sql.tests.connect.test_connect_column'