Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR is a followup of #39047 which import BinaryType that's removed in #39050. This was a logical conflict.

Why are the changes needed?

To recover the build.

Does this PR introduce any user-facing change?

No, test-only.

How was this patch tested?

Manually verified by running ./dev/lint-python.

@HyukjinKwon HyukjinKwon changed the title [SPARK-41506][CONNECT][TESTS][FOLLOW-UP] Import BinaryType [SPARK-41506][CONNECT][TESTS][FOLLOW-UP] Import BinaryType in pyspark.sql.tests.connect.test_connect_column Dec 14, 2022
@HyukjinKwon
Copy link
Member Author

I am going to merge this to fix up the build.

@HyukjinKwon
Copy link
Member Author

Merged to master.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@zhengruifeng
Copy link
Contributor

thank you @HyukjinKwon for this fix

beliefer pushed a commit to beliefer/spark that referenced this pull request Dec 18, 2022
….sql.tests.connect.test_connect_column

### What changes were proposed in this pull request?

This PR is a followup of apache#39047 which import `BinaryType` that's removed in apache#39050. This was a logical conflict.

### Why are the changes needed?

To recover the build.

### Does this PR introduce _any_ user-facing change?

No, test-only.

### How was this patch tested?

Manually verified by running `./dev/lint-python`.

Closes apache#39055 from HyukjinKwon/SPARK-41506-followup.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
@HyukjinKwon HyukjinKwon deleted the SPARK-41506-followup branch January 15, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants