Skip to content

[SPARK-41412][CONNECT][TESTS][FOLLOW-UP] Exclude binary casting to make the tests to pass with/without ANSI mode #39050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HyukjinKwon wants to merge 2 commits into from
Closed

[SPARK-41412][CONNECT][TESTS][FOLLOW-UP] Exclude binary casting to make the tests to pass with/without ANSI mode #39050

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bfff58
Exclude binary to make the tests to pass with/without ANSI mode
HyukjinKwon Dec 13, 2022
13d6076
Remove unused import
HyukjinKwon Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 15 additions & 20 deletions python/pyspark/sql/tests/connect/test_connect_column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
DoubleType,
LongType,
DecimalType,
BinaryType,
BooleanType,
)
from pyspark.testing.connectutils import should_test_connect
Expand Down Expand Up @@ -153,25 +152,21 @@ def test_cast(self):
df.select(df.id.cast("string")).toPandas(), df2.select(df2.id.cast("string")).toPandas()
)

# Test if the arguments can be passed properly.
# Do not need to check individual behaviour for the ANSI mode thoroughly.
with self.sql_conf({"spark.sql.ansi.enabled": False}):
for x in [
StringType(),
BinaryType(),
ShortType(),
IntegerType(),
LongType(),
FloatType(),
DoubleType(),
ByteType(),
DecimalType(10, 2),
BooleanType(),
DayTimeIntervalType(),
]:
self.assert_eq(
df.select(df.id.cast(x)).toPandas(), df2.select(df2.id.cast(x)).toPandas()
)
for x in [
StringType(),
ShortType(),
IntegerType(),
LongType(),
FloatType(),
DoubleType(),
ByteType(),
DecimalType(10, 2),
BooleanType(),
DayTimeIntervalType(),
]:
self.assert_eq(
df.select(df.id.cast(x)).toPandas(), df2.select(df2.id.cast(x)).toPandas()
)

def test_unsupported_functions(self):
# SPARK-41225: Disable unsupported functions.
Expand Down