[SPARK-41247][BUILD] Unify the Protobuf versions in Spark connect and Protobuf connector #38783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Nov 24, 2022
Contributor
|
shall we also shade protobuf in Spark Core in this PR? Then the proto version is unified in all the places. |
Co-authored-by: Wenchen Fan <[email protected]>
Member
Author
In this PR there is no actual usage. I would prefer to shade it in #38779 |
cloud-fan
approved these changes
Nov 24, 2022
zhengruifeng
approved these changes
Nov 24, 2022
Contributor
zhengruifeng
left a comment
zhengruifeng
left a comment
There was a problem hiding this comment.
lgtm, also cc @HyukjinKwon @grundprinzip
grundprinzip
approved these changes
Nov 24, 2022
HyukjinKwon
approved these changes
Nov 24, 2022
Member
Author
|
Merging to master |
Contributor
|
Now the protobuf version is unified for the scala side (or a few module of the scala side). But it is still different from the Python side (at least Connect Python client): #38774 |
HyukjinKwon
pushed a commit
that referenced
this pull request
Dec 6, 2022
…uf version ### What changes were proposed in this pull request? #38783 unify the Protobuf versions in Spark connect and Protobuf connector to `3.21.9` for maven, but sbt build and test still use `3.21.1`, so this pr make sbt also use Protobuf 3.21.9 to build and test. ### Why are the changes needed? Make sbt and maven use the same Protobuf version for build and test ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass Github Actions Closes #38926 from LuciferYang/SPARK-41247-FOLLOWUP. Authored-by: yangjie01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
… Protobuf connector ### What changes were proposed in this pull request? Unify the Protobuf versions in Spark connect and Protobuf connector. ### Why are the changes needed? The Protobuf dependencies will have the same behavior. And future upgrades will be easier. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? GA tests Closes apache#38783 from gengliangwang/unifyProtobufVersion. Lead-authored-by: Gengliang Wang <[email protected]> Co-authored-by: Gengliang Wang <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
… Protobuf connector ### What changes were proposed in this pull request? Unify the Protobuf versions in Spark connect and Protobuf connector. ### Why are the changes needed? The Protobuf dependencies will have the same behavior. And future upgrades will be easier. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? GA tests Closes apache#38783 from gengliangwang/unifyProtobufVersion. Lead-authored-by: Gengliang Wang <[email protected]> Co-authored-by: Gengliang Wang <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…uf version ### What changes were proposed in this pull request? apache#38783 unify the Protobuf versions in Spark connect and Protobuf connector to `3.21.9` for maven, but sbt build and test still use `3.21.1`, so this pr make sbt also use Protobuf 3.21.9 to build and test. ### Why are the changes needed? Make sbt and maven use the same Protobuf version for build and test ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass Github Actions Closes apache#38926 from LuciferYang/SPARK-41247-FOLLOWUP. Authored-by: yangjie01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Unify the Protobuf versions in Spark connect and Protobuf connector.
Why are the changes needed?
The Protobuf dependencies will have the same behavior. And future upgrades will be easier.
Does this PR introduce any user-facing change?
No
How was this patch tested?
GA tests