[SPARK-41247][BUILD][FOLLOWUP] Make sbt and maven use the same Protobuf version #38926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
LGTM Could you add |
Contributor
Author
|
I'm not sure whether |
dongjoon-hyun
approved these changes
Dec 6, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM.
[SPARK-41247][BUILD][FOLLOWUP] is correct.
Contributor
Author
|
Thanks for your confirmation @dongjoon-hyun |
gengliangwang
approved these changes
Dec 6, 2022
zhengruifeng
approved these changes
Dec 6, 2022
Contributor
zhengruifeng
left a comment
zhengruifeng
left a comment
There was a problem hiding this comment.
also cc @grundprinzip
Contributor
Author
|
All test passed |
Member
|
Merged to master. |
Contributor
Author
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…uf version ### What changes were proposed in this pull request? apache#38783 unify the Protobuf versions in Spark connect and Protobuf connector to `3.21.9` for maven, but sbt build and test still use `3.21.1`, so this pr make sbt also use Protobuf 3.21.9 to build and test. ### Why are the changes needed? Make sbt and maven use the same Protobuf version for build and test ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass Github Actions Closes apache#38926 from LuciferYang/SPARK-41247-FOLLOWUP. Authored-by: yangjie01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#38783 unify the Protobuf versions in Spark connect and Protobuf connector to
3.21.9for maven, but sbt build and test still use3.21.1, so this pr make sbt also use Protobuf 3.21.9 to build and test.Why are the changes needed?
Make sbt and maven use the same Protobuf version for build and test
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass Github Actions