[SPARK-41240][CONNECT][BUILD][INFRA][DOCS] Upgrade Protobuf to 3.19.5
#38774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornjorgensen
changed the title
Protobuf to 3.19.5Protobuf to 3.19.5
bjornjorgensen
changed the title
Protobuf to 3.19.5Protobuf to 3.19.5
Contributor
|
we may also need to change this place https://github.com/apache/spark/blob/master/connector/connect/src/main/buf.gen.yaml#L30 |
Contributor
|
There is currently no updated version on the buf schema registry. Given that this runs remotely, I think we're good for now. Mayber we can leave a comment with a todo JIRA? |
Contributor
bjornjorgensen
changed the title
Protobuf to 3.19.5Protobuf to 3.19.5
Contributor
|
create https://issues.apache.org/jira/browse/SPARK-41265 to track buf.build/protocolbuffers/plugins/python |
zhengruifeng
approved these changes
Nov 25, 2022
Contributor
|
merged into master |
|
Can one of the admins verify this patch? |
Contributor
|
Question: Should we keep the protobuf version in sync between the server and client? The server side now is using: |
Contributor
|
Just found an effort to unify the protobuf version which impacted connect server: #38783 |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
### What changes were proposed in this pull request? Upgrade Protobuf from 3.19.4 to 3.19.5 ### Why are the changes needed? [CVE-2022-1941](https://nvd.nist.gov/vuln/detail/CVE-2022-1941) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA Closes apache#38774 from bjornjorgensen/protobuf-3.19.5. Lead-authored-by: Bjørn Jørgensen <[email protected]> Co-authored-by: Bjorn Jorgensen <[email protected]> Co-authored-by: Bjørn <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? Upgrade Protobuf from 3.19.4 to 3.19.5 ### Why are the changes needed? [CVE-2022-1941](https://nvd.nist.gov/vuln/detail/CVE-2022-1941) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA Closes apache#38774 from bjornjorgensen/protobuf-3.19.5. Lead-authored-by: Bjørn Jørgensen <[email protected]> Co-authored-by: Bjorn Jorgensen <[email protected]> Co-authored-by: Bjørn <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade Protobuf from 3.19.4 to 3.19.5
Why are the changes needed?
CVE-2022-1941
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA