HDDS-8903. Add validation for ozone.om.snapshot.db.max.open.files. #8787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ibea7a7da9a170b9498f56bd62c3f37b354d81a05
jojochuang
added
snapshot
ayushtkn
approved these changes
Jul 11, 2025
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshotManager.java
Show resolved
Hide resolved
Change-Id: Icc34ef94de9aff4c3406a2f88d8735c799a2bdc8
swamirishi
reviewed
Jul 17, 2025
| OZONE_OM_SNAPSHOT_DB_MAX_OPEN_FILES, | ||
| OZONE_OM_SNAPSHOT_DB_MAX_OPEN_FILES_DEFAULT | ||
| ); | ||
| Preconditions.checkArgument(this.maxOpenSstFilesInSnapshotDb > 0, |
Contributor
There was a problem hiding this comment.
@jojochuang even 0 & -1 should be allowed. Rocksdb allows these values.
-1: Use unlimited number of open files (not recommended unless you manage file descriptors externally).
0: RocksDB will open file descriptors on demand, and cache only a small number (like table readers) — suitable for low file descriptor environments.
Greater than 0: RocksDB will keep up to this number of files open at once. The typical value is in the hundreds or thousands, depending on your OS limits.
Member
|
@jojochuang can you give a check to this: #8787 (comment) |
Contributor
|
Thanks @jojochuang for the original patch.
Thanks @swamirishi , @ayushtkn . Filed HDDS-13473 |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Jul 22, 2025
* master: (90 commits) HDDS-13308. OM should expose Ratis config for increasing pending write limits (apache#8668) HDDS-8903. Add validation for ozone.om.snapshot.db.max.open.files. (apache#8787) HDDS-13429. Custom metadata headers with uppercase characters are not supported (apache#8805) HDDS-13448. DeleteBlocksCommandHandler thread stop for normal exception (apache#8816) HDDS-13346. Intermittent failure in TestCloseContainer#testContainerChecksumForClosedContainer (apache#8771) HDDS-13125. Add metrics for monitoring the SST file pruning threads. (apache#8764) HDDS-13367. [Docs] User doc for container balancer. (apache#8726) HDDS-13200. OM RocksDB Grafana Dashbroad shows no data on all panels (apache#8577) HDDS-13428. Recon - Retrigger of build whole NSSummary tree task submission inconsistency. (apache#8793) HDDS-13378. [Docs] Add a Production page under Getting Started (apache#8734) HDDS-13403. [Docs] Make feature proposal process more visible. (apache#8758) HDDS-11797. Remove cyclic dependency between SCMSafeModeManager and SafeModeRules (apache#8782) HDDS-13213. KeyDeletingService should limit task size by both key count and serialized size. (apache#8757) HDDS-13387. OMSnapshotCreateRequest logs invalid warning about DefaultReplicationConfig (apache#8760) HDDS-13405. ozone admin container create runs forever without kinit (apache#8765) HDDS-11514. Set optimal default values for delete configurations based on live cluster testing. (apache#8766) HDDS-13376. Add server-side limit note to ozone sh snapshot diff --page-size option (apache#8791) HDDS-11679. Support multiple S3Gs in MiniOzoneCluster (apache#8733) HDDS-13424. Use lsof instead of fuser to find if file is used in AbstractTestChunkManager (apache#8790) HDDS-13427. Bump awssdk to 2.31.78 (apache#8792) ...
jojochuang
added a commit
to jojochuang/ozone
that referenced
this pull request
Jul 31, 2025
…pache#8787) Generated-by: Google Gemini 2.5 Pro + Gemini Cli
Gargi-jais11
pushed a commit
to Gargi-jais11/ozone
that referenced
this pull request
Aug 19, 2025
…pache#8787) Generated-by: Google Gemini 2.5 Pro + Gemini Cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-8903. Add validation for ozone.om.snapshot.db.max.open.files.
Please describe your PR in detail:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8903
How was this patch tested?
mvn test -pl hadoop-ozone/ozone-manager -Dtest=TestOmSnapshotManager