Skip to content

HDDS-8903. Add validation for ozone.om.snapshot.db.max.open.files. #8787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jojochuang merged 2 commits into from
Jul 17, 2025
Merged

HDDS-8903. Add validation for ozone.om.snapshot.db.max.open.files. #8787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02cfb1c
HDDS-8903. Add validation for ozone.om.snapshot.db.max.open.files.
jojochuang Jul 11, 2025
01ae586
HDDS-8903. Add validation for ozone.om.snapshot.db.max.open.files
jojochuang Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,9 @@ public OmSnapshotManager(OzoneManager ozoneManager) {
OZONE_OM_SNAPSHOT_DB_MAX_OPEN_FILES,
OZONE_OM_SNAPSHOT_DB_MAX_OPEN_FILES_DEFAULT
);
Preconditions.checkArgument(this.maxOpenSstFilesInSnapshotDb > 0,
Copy link
Contributor

@swamirishi swamirishi Jul 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jojochuang even 0 & -1 should be allowed. Rocksdb allows these values.
-1: Use unlimited number of open files (not recommended unless you manage file descriptors externally).

0: RocksDB will open file descriptors on demand, and cache only a small number (like table readers) — suitable for low file descriptor environments.

Greater than 0: RocksDB will keep up to this number of files open at once. The typical value is in the hundreds or thousands, depending on your OS limits.

OZONE_OM_SNAPSHOT_DB_MAX_OPEN_FILES + " must be positive.");

ColumnFamilyHandle snapDiffJobCf;
ColumnFamilyHandle snapDiffReportCf;
ColumnFamilyHandle snapDiffPurgedJobCf;
Expand Down
10 changes: 10 additions & 0 deletions ...p-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshotManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,4 +749,14 @@ private SnapshotInfo createSnapshotInfo(String volumeName,
UUID.randomUUID(),
Time.now());
}

@Test
void testNegativeMaxOpenFiles(@TempDir File tempDir) throws Exception {
OzoneConfiguration conf = new OzoneConfiguration();
conf.set(HddsConfigKeys.OZONE_METADATA_DIRS, tempDir.getAbsolutePath());
conf.setInt(OMConfigKeys.OZONE_OM_SNAPSHOT_DB_MAX_OPEN_FILES, 0);
conf.setBoolean(OMConfigKeys.OZONE_FILESYSTEM_SNAPSHOT_ENABLED_KEY, true);

assertThrows(IllegalArgumentException.class, () -> new OmTestManagers(conf));
}
}