HDDS-13308. OM should expose Ratis config for increasing pending write limits #8668
Conversation
…g write byte limit Change-Id: Ief5ca5e8241a5a1457537927d4827bce761bbe59
adoroszlai
changed the title
ivandika3
left a comment
ivandika3
left a comment
There was a problem hiding this comment.
Thanks @swamirishi for the patch. Left some comments.
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
Outdated
Show resolved
Hide resolved
Change-Id: If1b45518746793c4ac0a13af69f88e640396419c
Change-Id: I7e95083d0c39f6877019a9690de890ae9d921718
|
@ivandika3 sorry for the delay in addressing the review comments. If we are good we can change merge the issue. |
ivandika3
left a comment
ivandika3
left a comment
There was a problem hiding this comment.
@swamirishi Thanks for the update. LGTM +1.
|
Thanks @ivandika3 for reviewing the patch. |
* master: (90 commits) HDDS-13308. OM should expose Ratis config for increasing pending write limits (apache#8668) HDDS-8903. Add validation for ozone.om.snapshot.db.max.open.files. (apache#8787) HDDS-13429. Custom metadata headers with uppercase characters are not supported (apache#8805) HDDS-13448. DeleteBlocksCommandHandler thread stop for normal exception (apache#8816) HDDS-13346. Intermittent failure in TestCloseContainer#testContainerChecksumForClosedContainer (apache#8771) HDDS-13125. Add metrics for monitoring the SST file pruning threads. (apache#8764) HDDS-13367. [Docs] User doc for container balancer. (apache#8726) HDDS-13200. OM RocksDB Grafana Dashbroad shows no data on all panels (apache#8577) HDDS-13428. Recon - Retrigger of build whole NSSummary tree task submission inconsistency. (apache#8793) HDDS-13378. [Docs] Add a Production page under Getting Started (apache#8734) HDDS-13403. [Docs] Make feature proposal process more visible. (apache#8758) HDDS-11797. Remove cyclic dependency between SCMSafeModeManager and SafeModeRules (apache#8782) HDDS-13213. KeyDeletingService should limit task size by both key count and serialized size. (apache#8757) HDDS-13387. OMSnapshotCreateRequest logs invalid warning about DefaultReplicationConfig (apache#8760) HDDS-13405. ozone admin container create runs forever without kinit (apache#8765) HDDS-11514. Set optimal default values for delete configurations based on live cluster testing. (apache#8766) HDDS-13376. Add server-side limit note to ozone sh snapshot diff --page-size option (apache#8791) HDDS-11679. Support multiple S3Gs in MiniOzoneCluster (apache#8733) HDDS-13424. Use lsof instead of fuser to find if file is used in AbstractTestChunkManager (apache#8790) HDDS-13427. Bump awssdk to 2.31.78 (apache#8792) ...
@swamirishi , in OM, all the ratis confs can be set by using the "ozone.om.ha" prefix. In this case, the existing conf before this PR is
Why adding "pending" in the new conf below? It seems to be quite confusing.
|
|
@swamirishi , since we already have an existing conf |
|
sure @szetszwo let us revert this change I didn't realize this change was there. In this case should we not deprecate al the configs I got confused because there were a few configs like this ozone/hadoop-hdds/common/src/main/resources/ozone-default.xml Lines 2227 to 2234 in 11286d9 which are redundant we should deprecate these configs since configs like these could conflict with their prefix counterparts. |
That's great! Could you revert it? |
|
@swamirishi , it would be great if you could follow up promptly for the problems you have introduced. The Apache Ozone community thanks you! |
3 participants
What changes were proposed in this pull request?
Given that background services in OM are going to submit multiple requests in parallel then there should be a way to increase raft.server.write.byte-limit for om which is not configurable now. Adding the config to make the RaftProperty configurable.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13308
How was this patch tested?
Adding configuration no additional tests required.