Skip to content

HDDS-13376. Add server-side limit note to ozone sh snapshot diff --page-size option #8791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ivandika3 merged 1 commit into from
Jul 13, 2025
Merged

HDDS-13376. Add server-side limit note to ozone sh snapshot diff --page-size option #8791

ivandika3 merged 1 commit into from
Jul 13, 2025

Conversation

@smengcl
Copy link
Contributor

@smengcl smengcl commented Jul 12, 2025

What changes were proposed in this pull request?

Add a note to the page-size option of ozone sh snapshot diff that server-side config ozone.om.snapshot.diff.max.page.size would also be a limiting factor.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13376

How was this patch tested?

  • Updated CLI help print:
bash-5.1$ ozone sh snapshot diff -h
Usage: ozone sh snapshot diff [-chV] [--json] [--verbose] [-p=<pageSize>]
                              [-t=<token>] <value> <fromSnapshot> <toSnapshot>
Get the differences between two snapshots
      <value>           URI of the bucket (format: volume/bucket).
...
  -p, --page-size=<pageSize>
                        number of diff entries to be returned in the response.
                          Note the effective page size will also be bound by
                          the server-side page size limit, see config:
                          ozone.om.snapshot.diff.max.page.size
                          Default: 1000

@ivandika3 ivandika3 added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Jul 12, 2025
ivandika3
ivandika3 approved these changes Jul 12, 2025
View reviewed changes
Copy link
Contributor

@ivandika3 ivandika3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement. LGTM +1.

@ivandika3 ivandika3 merged commit fb75be7 into apache:master Jul 13, 2025
42 checks passed
@ivandika3
Copy link
Contributor

ivandika3 commented Jul 13, 2025

Thanks @smengcl for the patch and @adoroszlai for pointing out the server-side limit.

errose28 added a commit to errose28/ozone that referenced this pull request Jul 22, 2025
@errose28
Merge branch 'master' into HDDS-13083-handle-empty-mt
6b4188f 
* master: (90 commits)
  HDDS-13308. OM should expose Ratis config for increasing pending write limits (apache#8668)
  HDDS-8903. Add validation for ozone.om.snapshot.db.max.open.files. (apache#8787)
  HDDS-13429. Custom metadata headers with uppercase characters are not supported (apache#8805)
  HDDS-13448. DeleteBlocksCommandHandler thread stop for normal exception (apache#8816)
  HDDS-13346. Intermittent failure in TestCloseContainer#testContainerChecksumForClosedContainer (apache#8771)
  HDDS-13125. Add metrics for monitoring the SST file pruning threads. (apache#8764)
  HDDS-13367. [Docs] User doc for container balancer. (apache#8726)
  HDDS-13200. OM RocksDB Grafana Dashbroad shows no data on all panels (apache#8577)
  HDDS-13428. Recon - Retrigger of build whole NSSummary tree task submission inconsistency. (apache#8793)
  HDDS-13378. [Docs] Add a Production page under Getting Started (apache#8734)
  HDDS-13403. [Docs] Make feature proposal process more visible. (apache#8758)
  HDDS-11797. Remove cyclic dependency between SCMSafeModeManager and SafeModeRules (apache#8782)
  HDDS-13213. KeyDeletingService should limit task size by both key count and serialized size. (apache#8757)
  HDDS-13387. OMSnapshotCreateRequest logs invalid warning about DefaultReplicationConfig (apache#8760)
  HDDS-13405. ozone admin container create runs forever without kinit (apache#8765)
  HDDS-11514. Set optimal default values for delete configurations based on live cluster testing. (apache#8766)
  HDDS-13376. Add server-side limit note to ozone sh snapshot diff --page-size option (apache#8791)
  HDDS-11679. Support multiple S3Gs in MiniOzoneCluster (apache#8733)
  HDDS-13424. Use lsof instead of fuser to find if file is used in AbstractTestChunkManager (apache#8790)
  HDDS-13427. Bump awssdk to 2.31.78 (apache#8792)
  ...
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Jul 31, 2025
@smengcl @jojochuang
HDDS-13376. Add server-side limit note to ozone sh snapshot diff --pa…
8c7c782 
…ge-size option (apache#8791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivandika3 ivandika3 ivandika3 approved these changes

Assignees

No one assigned

Labels

snapshot https://issues.apache.org/jira/browse/HDDS-6517

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smengcl @ivandika3