Skip to content

Conversation

@ChenSammi
Copy link
Contributor

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ChenSammi for the patch.

Longer expiry time requires more sleep, which increases test execution time. Can we change the test to use TestClock instead for finer control over "time" and quicker execution?

Also, we'd need repeated executions to verify the test is no longer flaky (example).

@ChenSammi
Copy link
Contributor Author

ChenSammi commented Jan 6, 2023

Thanks @adoroszlai for the info. TestClock is not easy to used here since the certificate validity check is down by the underline SSL infra. But I use another way to improve the execution time of testCertificateLifetime. 100x run is applied now.

@adoroszlai
Copy link
Contributor

100x run is applied now.

Thanks. It should be done in a separate branch, which only has the repeated CI tweak on top of the original patch branch, as we don't want to merge that part of the change.

@ChenSammi
Copy link
Contributor Author

Sure, I created #4151 for the 100x run .

@adoroszlai
Copy link
Contributor

Sure, I created #4151 for the 100x run.

Thanks. No PR is needed for the 100x run, CI in your fork is enough: https://github.com/ChenSammi/ozone/actions/runs/3856056896

@ChenSammi
Copy link
Contributor Author

ChenSammi commented Jan 6, 2023

Sure, I created #4151 for the 100x run.

Thanks. No PR is needed for the 100x run, CI in your fork is enough: https://github.com/ChenSammi/ozone/actions/runs/3856056896

How the CI in forked repo is triggered? Automatically?

@adoroszlai
Copy link
Contributor

How the CI in forked repo is triggered? Automatically?

Yes, triggered automatically by pushing to your fork.

@ChenSammi
Copy link
Contributor Author

How the CI in forked repo is triggered? Automatically?

Yes, triggered automatically by pushing to your fork.

I see. Thanks, @adoroszlai .

@ChenSammi ChenSammi merged commit a1cb9d5 into apache:master Jan 9, 2023
@ChenSammi
Copy link
Contributor Author

Thanks @adoroszlai .

errose28 added a commit to errose28/ozone that referenced this pull request Jan 9, 2023
* master: (176 commits)
  HDDS-7726. EC: Enhance datanode reconstruction log message (apache#4155)
  HDDS-7739. EC: Increase the information in the RM sending command log message (apache#4153)
  HDDS-7652. Volume Quota not enforced during write when bucket quota is not set (apache#4124)
  HDDS-7628. Intermittent failure in TestOzoneContainerWithTLS (apache#4142)
  HDDS-7695. EC metrics related to replication commands don't add up (apache#4152)
  HDDS-7729. EC: ECContainerReplicaCount should handle pending delete of unhealthy replicas (apache#4146)
  HDDS-7738. SCM terminates when adding container to a closed pipeline (apache#4154)
  HDDS-7243. Remove RequestFeatureValidator from echoRPC method which supports only ValidationCondition.OLDER_CLIENT_REQUESTS (apache#4051)
  HDDS-7708. No check for certificate duration config scenarios. (apache#4149)
  HDDS-7727. EC: SCM unregistered event handler for DatanodeCommandCountUpdated (apache#4147)
  HDDS-7606. Add SCM HA support in intellij run (apache#4058)
  HDDS-7666. EC: Unrecoverable EC containers with some remaining replicas may block decommissioning (apache#4118)
  HDDS-7339. Implement Certificate renewal task for services (apache#3982)
  HDDS-7696. MisReplicationHandler does not consider QUASI_CLOSED replicas as sources (apache#4144)
  HDDS-7714. Docker cluster ozone-om-ha fails during docker-compose up (apache#4137)
  HDDS-7716. Log read requests rejected with permission denied in OM audit (apache#4136)
  HDDS-7588. Intermittent failure in TestObjectStoreWithLegacyFS#testFlatKeyStructureWithOBS (apache#4040)
  HDDS-7633. Compile error with Java 11: package com.sun.jmx.mbeanserver is not visible (apache#4077)
  HDDS-7648. Add a servername tag in UGI metrics. (apache#4094)
  HDDS-7564. Update Ozone version after 1.3.0 release (apache#4115)
  ...
@ChenSammi ChenSammi deleted the HDDS-7628 branch February 20, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants