HDDS-7716. Add ACL errors to OM audit logs for read requests #4136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myskov
changed the title
adoroszlai
reviewed
Jan 2, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @myskov for the patch. LGTM overall.
Comment on lines
-2885
to
-2890
| if (isAclEnabled) { | ||
| captureLatencyNs(perfMetrics.getGetKeyInfoAclCheckLatencyNs(), () -> | ||
| checkAcls(ResourceType.KEY, StoreType.OZONE, ACLType.READ, | ||
| bucket.realVolume(), bucket.realBucket(), args.getKeyName()) | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
There is a similar call in lookupKey which is not moved into the try-catch block.
| /** | ||
| * Utility class to read audit logs. | ||
| */ | ||
| public final class AuditLogUtils { |
Contributor
There was a problem hiding this comment.
Since this is only for tests, I think AuditLogTestUtils would be better. Also, moving it to hdds-common (e.g. in hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit) would allow more reuse.
For that s3gateway dependencies would need a new entry like:
ozone/hadoop-ozone/ozone-manager/pom.xml
Lines 106 to 111 in b352ad0
kerneltime
changed the title
adoroszlai
approved these changes
Jan 3, 2023
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Jan 9, 2023
* master: (176 commits) HDDS-7726. EC: Enhance datanode reconstruction log message (apache#4155) HDDS-7739. EC: Increase the information in the RM sending command log message (apache#4153) HDDS-7652. Volume Quota not enforced during write when bucket quota is not set (apache#4124) HDDS-7628. Intermittent failure in TestOzoneContainerWithTLS (apache#4142) HDDS-7695. EC metrics related to replication commands don't add up (apache#4152) HDDS-7729. EC: ECContainerReplicaCount should handle pending delete of unhealthy replicas (apache#4146) HDDS-7738. SCM terminates when adding container to a closed pipeline (apache#4154) HDDS-7243. Remove RequestFeatureValidator from echoRPC method which supports only ValidationCondition.OLDER_CLIENT_REQUESTS (apache#4051) HDDS-7708. No check for certificate duration config scenarios. (apache#4149) HDDS-7727. EC: SCM unregistered event handler for DatanodeCommandCountUpdated (apache#4147) HDDS-7606. Add SCM HA support in intellij run (apache#4058) HDDS-7666. EC: Unrecoverable EC containers with some remaining replicas may block decommissioning (apache#4118) HDDS-7339. Implement Certificate renewal task for services (apache#3982) HDDS-7696. MisReplicationHandler does not consider QUASI_CLOSED replicas as sources (apache#4144) HDDS-7714. Docker cluster ozone-om-ha fails during docker-compose up (apache#4137) HDDS-7716. Log read requests rejected with permission denied in OM audit (apache#4136) HDDS-7588. Intermittent failure in TestObjectStoreWithLegacyFS#testFlatKeyStructureWithOBS (apache#4040) HDDS-7633. Compile error with Java 11: package com.sun.jmx.mbeanserver is not visible (apache#4077) HDDS-7648. Add a servername tag in UGI metrics. (apache#4094) HDDS-7564. Update Ozone version after 1.3.0 release (apache#4115) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
adding log entries to OM audit log in case a request is prohibited by ACL policies. Also, a way of testing audit logs is added along with integration tests (see AuditLogUtils.class).
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7716
How was this patch tested?