Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Fix error when compiling Ozone for target Java version 11:

$ mvn -Djavac.version=11 -DskipTests clean package
...
[ERROR] hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:[74,19] package com.sun.jmx.mbeanserver is not visible
[ERROR]   (package com.sun.jmx.mbeanserver is declared in module java.management, which does not export it)

Change compile CI check so that it, in addition to using JDK of the specified version, also targets the same Java version. This way we can catch such errors in CI.

https://issues.apache.org/jira/browse/HDDS-7633

How was this patch tested?

$ mvn -Djavac.version=11 -DskipTests clean package
...
[INFO] BUILD SUCCESS

https://github.com/adoroszlai/hadoop-ozone/actions/runs/3687864892/jobs/6242414957

@adoroszlai adoroszlai self-assigned this Dec 13, 2022
@adoroszlai adoroszlai added the build Pull request that modifies the build process label Dec 13, 2022
@kerneltime kerneltime self-requested a review December 19, 2022 17:13
@kerneltime
Copy link
Contributor

cc @GeorgeJahad can you please take a look.

@adoroszlai adoroszlai merged commit 04f68c9 into apache:master Jan 3, 2023
@adoroszlai adoroszlai deleted the HDDS-7633 branch January 3, 2023 13:56
@adoroszlai
Copy link
Contributor Author

Thanks @kerneltime for the review.

errose28 added a commit to errose28/ozone that referenced this pull request Jan 9, 2023
* master: (176 commits)
  HDDS-7726. EC: Enhance datanode reconstruction log message (apache#4155)
  HDDS-7739. EC: Increase the information in the RM sending command log message (apache#4153)
  HDDS-7652. Volume Quota not enforced during write when bucket quota is not set (apache#4124)
  HDDS-7628. Intermittent failure in TestOzoneContainerWithTLS (apache#4142)
  HDDS-7695. EC metrics related to replication commands don't add up (apache#4152)
  HDDS-7729. EC: ECContainerReplicaCount should handle pending delete of unhealthy replicas (apache#4146)
  HDDS-7738. SCM terminates when adding container to a closed pipeline (apache#4154)
  HDDS-7243. Remove RequestFeatureValidator from echoRPC method which supports only ValidationCondition.OLDER_CLIENT_REQUESTS (apache#4051)
  HDDS-7708. No check for certificate duration config scenarios. (apache#4149)
  HDDS-7727. EC: SCM unregistered event handler for DatanodeCommandCountUpdated (apache#4147)
  HDDS-7606. Add SCM HA support in intellij run (apache#4058)
  HDDS-7666. EC: Unrecoverable EC containers with some remaining replicas may block decommissioning (apache#4118)
  HDDS-7339. Implement Certificate renewal task for services (apache#3982)
  HDDS-7696. MisReplicationHandler does not consider QUASI_CLOSED replicas as sources (apache#4144)
  HDDS-7714. Docker cluster ozone-om-ha fails during docker-compose up (apache#4137)
  HDDS-7716. Log read requests rejected with permission denied in OM audit (apache#4136)
  HDDS-7588. Intermittent failure in TestObjectStoreWithLegacyFS#testFlatKeyStructureWithOBS (apache#4040)
  HDDS-7633. Compile error with Java 11: package com.sun.jmx.mbeanserver is not visible (apache#4077)
  HDDS-7648. Add a servername tag in UGI metrics. (apache#4094)
  HDDS-7564. Update Ozone version after 1.3.0 release (apache#4115)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Pull request that modifies the build process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants