HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated #2243
Conversation
guihecheng
force-pushed
the
HDDS-5219
branch
3 times, most recently
from
005f3b0 to
34cf431
Compare
|
Hi @bshashikant @ChenSammi , the config support is added as you suggested, please help review this, thanks~ |
There was a problem hiding this comment.
DFSConfigKeysLegacy is a deprecated Class. Since Ozone is spinned out from Hadoop, as a new project, we should avoid use HDFS configuration key anymore. We can define a similar key for Ozone.
There was a problem hiding this comment.
@ChenSammi oh, then I shall add this key in some other place.
There was a problem hiding this comment.
What's the difference of if else here, could you do a little explaination?
There was a problem hiding this comment.
This logic is borrowed from hdfs, when we set this 'tolerated' to -1, we mean unlimited number of bad volumes but we still should have at least 1 good volume left.
Otherwise, we should have fewer or equal number of bad volumes.
There was a problem hiding this comment.
Can you add some comments here?
There was a problem hiding this comment.
@bshashikant sure, will cp the lines above into code comments.
There was a problem hiding this comment.
A more detail error message is preferred here since we know the right reason.
There was a problem hiding this comment.
sure, I'll put a more clear message here.
There was a problem hiding this comment.
Prefer more detail error message, such as how may volumes configured, and how many failed volumes.
|
@guihecheng , thanks for the work. The config needs to be defined in ozone-site.xml and should be well documented in ozone-default.xml. |
guihecheng
force-pushed
the
HDDS-5219
branch
2 times, most recently
from
b00c2a1 to
fc40473
Compare
There was a problem hiding this comment.
I feel, we should make the default as -1 rather than zero by default.
There was a problem hiding this comment.
@bshashikant here I borrowed the default 0 from HDFS to stay aligned, but I also think that -1 is reasonable.
With -1 as the default, we introduce no behavioral change to existing clusters when we have a few(1~2) volumes failed.
Will update, thanks.
bshashikant
left a comment
bshashikant
left a comment
There was a problem hiding this comment.
Looks good with minor suggestion.
|
@bshashikant updated, thanks |
…ing-upgrade-master-merge * upstream/master: (76 commits) HDDS-5280. Make XceiverClientManager creation when necessary in ContainerOperationClient (apache#2289) HDDS-5272. Make ozonefs.robot execution repeatable (apache#2280) HDDS-5123. Use the pre-created apache/ozone-testkrb5 image during secure acceptance tests (apache#2165) HDDS-4993. Add guardrail for reserved buffer size when DN reads a chunk (apache#2058) HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone (apache#2018) HDDS-4043. allow deletion from Trash directory without -skipTrash option (apache#2110) HDDS-4927. Determine over and under utilized datanodes in Container Balancer. (apache#2230) HDDS-5273. Handle unsecure cluster convert to secure cluster for SCM. (apache#2281) HDDS-5158. Add documentation for SCM HA Security. (apache#2205) HDDS-5275. Datanode Report Publisher publishes one extra report after DN shutdown (apache#2283) HDDS-5241. SCM UI should have leader/follower and Primordial SCM information (apache#2260) HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated. (apache#2243) HDDS-5252. PipelinePlacementPolicy filter out datanodes with not enough space. (apache#2271) HDDS-5191. Increase default pvc storage size (apache#2219) HDDS-5073. Use ReplicationConfig on client side (apache#2136) HDDS-5250. Build integration tests with Maven cache (apache#2269) HDDS-5236. Require block token for more operations (apache#2254) HDDS-5266 Misspelt words in S3MultipartUploadCommitPartRequest.java line 202 (apache#2279) HDDS-5249. Race Condition between Full and Incremental Container Reports (apache#2268) HDDS-5142. Make generic streaming client/service for container re-replication, data read, scm/om snapshot download (apache#2256) ... Conflicts: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/protocol/StorageContainerLocationProtocol.java hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocolPB/StorageContainerLocationProtocolClientSideTranslatorPB.java hadoop-hdds/interface-admin/src/main/proto/ScmAdminProtocol.proto hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/MockNodeManager.java hadoop-ozone/dist/src/main/compose/testlib.sh hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestStorageContainerManager.java hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto hadoop-ozone/ozone-manager/pom.xml hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java hadoop-ozone/s3gateway/pom.xml
3 participants
What changes were proposed in this pull request?
Datanode has config 'dfs.datanode.failed.volumes.tolerated', but it does not work,
this makes it to work.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5219
How was this patch tested?
a new integration-test case
an extended ut