Skip to content

Conversation

@yoowonsuk
Copy link
Contributor

@yoowonsuk yoowonsuk commented May 6, 2021

What changes were proposed in this pull request?

Containers are 5Gb by default, however pvc is 2Gb.
it needs to be changed.

What is the link to the Apache JIRA

HDDS-5191

How was this patch tested?

manual tests

@adoroszlai adoroszlai requested a review from elek May 10, 2021 06:41
Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you to report this issue @yoowonsuk

I agree with proposed change but having two comments:

  1. I think you can further increase this storage to 15Gi or 20Gi. If you use a storage where the space is really limited 5Gi may not be enough (especially as datanode can complain that there is not enough space for the containers if more than one container is opened at the same time).

  2. Can you please change all the related files:

examples/ozone/datanode-statefulset.yaml
72:          storage: 2Gi

definitions/ozone/definitions/persistence.yaml
32:              storage: 2Gi

examples/ozone-ha/datanode-statefulset.yaml
72:          storage: 2Gi

(examples files are generated from the definitions, but you shouldn't be worried just update both the definition and examples)

@dineshchitlangia dineshchitlangia changed the title pvc 2Gb -> 5Gb Increase default pvc storage size May 10, 2021
@yoowonsuk
Copy link
Contributor Author

Hello, @elek
Thank you for your comment.

  1. I agree with you in part. but the point is 2Gb by default isn't working properly. in other words we cannot put data in storage.
    So, if you are considering lack of storage, then what about put the config
    container size: 1GB with nothing change of pvc size.

  2. Despite first question, for now I just fixed the files. Thank you.

@cku328 cku328 changed the title Increase default pvc storage size HDDS-5191. Increase default pvc storage size May 11, 2021
Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks for the update @yoowonsuk

@yoowonsuk yoowonsuk requested a review from elek May 15, 2021 11:18
@elek
Copy link
Member

elek commented May 25, 2021

Merging it now. Thanks for the contribution @yoowonsuk

@elek elek merged commit 2dbf04e into apache:master May 25, 2021
errose28 added a commit to errose28/ozone that referenced this pull request Jun 1, 2021
…ing-upgrade-master-merge

* upstream/master: (76 commits)
  HDDS-5280. Make XceiverClientManager creation when necessary in ContainerOperationClient (apache#2289)
  HDDS-5272. Make ozonefs.robot execution repeatable (apache#2280)
  HDDS-5123. Use the pre-created apache/ozone-testkrb5 image during secure acceptance tests (apache#2165)
  HDDS-4993. Add guardrail for reserved buffer size when DN reads a chunk (apache#2058)
  HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone (apache#2018)
  HDDS-4043. allow deletion from Trash directory without -skipTrash option (apache#2110)
  HDDS-4927. Determine over and under utilized datanodes in Container Balancer. (apache#2230)
  HDDS-5273. Handle unsecure cluster convert to secure cluster for SCM. (apache#2281)
  HDDS-5158. Add documentation for SCM HA Security. (apache#2205)
  HDDS-5275. Datanode Report Publisher publishes one extra report after DN shutdown (apache#2283)
  HDDS-5241. SCM UI should have leader/follower and Primordial SCM information (apache#2260)
  HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated. (apache#2243)
  HDDS-5252. PipelinePlacementPolicy filter out datanodes with not enough space. (apache#2271)
  HDDS-5191. Increase default pvc storage size (apache#2219)
  HDDS-5073. Use ReplicationConfig on client side  (apache#2136)
  HDDS-5250. Build integration tests with Maven cache (apache#2269)
  HDDS-5236. Require block token for more operations (apache#2254)
  HDDS-5266 Misspelt words in S3MultipartUploadCommitPartRequest.java line 202 (apache#2279)
  HDDS-5249. Race Condition between Full and Incremental Container Reports (apache#2268)
  HDDS-5142. Make generic streaming client/service for container re-replication, data read, scm/om snapshot download (apache#2256)
  ...

Conflicts:
	hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/protocol/StorageContainerLocationProtocol.java
	hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocolPB/StorageContainerLocationProtocolClientSideTranslatorPB.java
	hadoop-hdds/interface-admin/src/main/proto/ScmAdminProtocol.proto
	hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
	hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/MockNodeManager.java
	hadoop-ozone/dist/src/main/compose/testlib.sh
	hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestStorageContainerManager.java
	hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
	hadoop-ozone/ozone-manager/pom.xml
	hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
	hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java
	hadoop-ozone/s3gateway/pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants