HDDS-4736. Intermittent failure in testExpiredCertificate #1838
Conversation
| IllegalStateException, IOException, OperatorCreationException { | ||
| Date from = new Date(); | ||
| Date from = new Date(Instant.now().toEpochMilli() - 100L); | ||
| Date to = new Date(from.getTime() + 100L); | ||
| return generateTestCert(dn, pair, algorithm, from, to); |
There was a problem hiding this comment.
Can we just do -
generateTestCert(dn, pair, algorithm, from, from);
Means eliminate the to and pass from only instead, rather than this?
There was a problem hiding this comment.
Thanks for the suggestion, have set endDate same as startDate.
| Date to = from; | ||
| return generateTestCert(dn, pair, algorithm, from, to); |
There was a problem hiding this comment.
you can directly pass from instead of to in generateTestCert
something like - generateTestCert(dn, pair, algorithm, from, from);
no need to have
Date to = from;
There was a problem hiding this comment.
Yes, but I think it may be more readable to keep the fields of "from" and "to"?
There was a problem hiding this comment.
For readability better to add a comment explaining why we are passing from for both arguments.
Though trivial assigning unnecessary would have cost and isn't a good practice IMO
There was a problem hiding this comment.
Got it. Have added a comment for readability.
adoroszlai
changed the title
|
@adoroszlai @ayushtkn Thanks for the review. |
|
Thanx @symious for the contribution and @adoroszlai for the review!!! |
* master: (176 commits) HDDS-4760. Intermittent failure in ozone-ha acceptance test (apache#1853) HDDS-4770. Upgrade Ratis Thirdparty to 0.6.0 (apache#1868) HDDS-4765. Update close-pending workflow for new repo (apache#1856) HDDS-4737. Add ModifierOrder to checkstyle rules (apache#1839) HDDS-4704. Add permission check in OMDBCheckpointServlet (apache#1801) HDDS-4757. Unnecessary WARNING to set OZONE_CONF_DIR (apache#1849) HDDS-4751. TestOzoneFileSystem#testTrash failed when enabledFileSystemPaths and omRatisDisabled (apache#1851) HDDS-4736. Intermittent failure in testExpiredCertificate (apache#1838) HDDS-4758. Adjust classpath of ozone version to include log4j (apache#1850) HDDS-4518. Add metrics around Trash Operations. (apache#1832) HDDS-4708. Optimization: update RetryCount less frequently (update once per ~100) (apache#1805) HDDS-4748. sonarqube issue fix - "static" members should be accessed statically (apache#1748) HDDS-2402. Adapt hadolint check to improved CI framework (apache#1778) HDDS-4698. Upgrade Java for Sonar check (apache#1800) HDDS-4739. Upgrade Ratis to 1.1.0-eb66796d-SNAPSHOT (apache#1842) HDDS-4735. Fix typo in hdds.proto (apache#1837) HDDS-4430. OM failover timeout is too short (apache#1807) HDDS-4477. Delete txnId in SCMMetadataStoreImpl may drop to 0 after SCM restart. (apache#1828) HDDS-4688. Update Hadoop version to 3.2.2 (apache#1795) HDDS-4725. Change metrics unit from nanosecond to millisecond (apache#1823) ...
3 participants
What changes were proposed in this pull request?
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4736
How was this patch tested?
Manual test.