HDDS-4757. Unnecessary WARNING to set OZONE_CONF_DIR

[elek]

What changes were proposed in this pull request?

I executed a simple ozone command ("ozone admin pipeline list") on my latest deploy and got a warning:

ozone admin pipeline list
WARNING: OZONE_CONF_DIR not defined and cannot be found, setting in OZONE_HOME: /opt/ozone/etc/hadoop.

Same with bash debug log (set -x):

++ local conf_dir=etc/hadoop
++ [[ -n '' ]]
++ [[ -n /opt/ozone ]]
++ ozone_verify_confdir /opt/ozone/etc/hadoop
++ [[ -f /log4j.properties ]]
++ [[ -n /opt/ozone/libexec ]]
++ ozone_verify_confdir /opt/ozone/libexec/../etc/hadoop
++ [[ -f /log4j.properties ]]
++ OZONE_CONF_DIR=/opt/ozone/etc/hadoop
++ ozone_error 'WARNING: OZONE_CONF_DIR not defined and cannot be found, setting in OZONE_HOME: /opt/ozone/etc/hadoop.'
++ echo 'WARNING: OZONE_CONF_DIR not defined and cannot be found, setting in OZONE_HOME: /opt/ozone/etc/hadoop.'
WARNING: OZONE_CONF_DIR not defined and cannot be found, setting in OZONE_HOME: /opt/ozone/etc/hadoop.

This error supposed to be hidden as conf dir is under the default location (/opt/ozone/etc/hadoop).

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4757

How was this patch tested?

Executed "ozone version" with and without the patch in your host os (without docker) whete HADOOP/OZONE_CONF_DIR is not set.

[adoroszlai]

Thanks @elek for finding and fixing this bug.

$ bin/ozone version
                  //////////////
               ////////////////////
            ////////     ////////////////
           //////      ////////////////
          /////      ////////////////  /
         /////            ////////   ///
         ////           ////////    /////
        /////         ////////////////
        /////       ////////////////   //
         ////     ///////////////   /////
         /////  ///////////////     ////
          /////       //////      /////
           //////   //////       /////
             ///////////     ////////
               //////  ////////////
               ///   //////////
              /    1.1.0-SNAPSHOT(Denali)

[adoroszlai]

@elek I have added an assertion to make sure this is covered by CI, hope you don't mind.

[elek]

@elek I have added an assertion to make sure this is covered by CI, hope you don't mind.

Absolutely, thank you very much.

OFF: I also noticed a few (false positive?) ERROR logs in the console. It's a different story, but similar: I am thinking to check all WARNINGS and ERRORS in the console output and the log and fail if any. (During normal run they shouldn't be there).