Skip to content

HDDS-4736. Intermittent failure in testExpiredCertificate #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayushtkn merged 3 commits into from
Jan 29, 2021
Merged

HDDS-4736. Intermittent failure in testExpiredCertificate #1838

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fe252e
HDDS-4736. Eliminate test failure caused by testExpiredCertificate
symious Jan 24, 2021
147b322
HDDS-4736. Change cert's endDate
symious Jan 25, 2021
8d8acbd
HDDS-4736. Add comment for better readability
symious Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ager/src/test/java/org/apache/hadoop/ozone/security/TestOzoneBlockTokenSecretManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ private X509Certificate generateExpiredCert(String dn,
KeyPair pair, String algorithm) throws CertificateException,
IllegalStateException, IOException, OperatorCreationException {
Date from = new Date();
Date to = new Date(from.getTime() + 100L);
Date to = from;
return generateTestCert(dn, pair, algorithm, from, to);
Copy link
Member

@ayushtkn ayushtkn Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can directly pass from instead of to in generateTestCert
something like - generateTestCert(dn, pair, algorithm, from, from);
no need to have
Date to = from;

Copy link
Contributor Author

@symious symious Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I think it may be more readable to keep the fields of "from" and "to"?

Copy link
Member

@ayushtkn ayushtkn Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For readability better to add a comment explaining why we are passing from for both arguments.
Though trivial assigning unnecessary would have cost and isn't a good practice IMO

Copy link
Contributor Author

@symious symious Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Have added a comment for readability.

}

Expand Down