HDDS-4751. TestOzoneFileSystem#testTrash failed when enabledFileSystemPaths and omRatisDisabled #1851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
changed the title
mukul1987
approved these changes
Jan 29, 2021
Contributor
mukul1987
left a comment
mukul1987
left a comment
There was a problem hiding this comment.
+1, the change looks good to me.
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Feb 1, 2021
* master: (176 commits) HDDS-4760. Intermittent failure in ozone-ha acceptance test (apache#1853) HDDS-4770. Upgrade Ratis Thirdparty to 0.6.0 (apache#1868) HDDS-4765. Update close-pending workflow for new repo (apache#1856) HDDS-4737. Add ModifierOrder to checkstyle rules (apache#1839) HDDS-4704. Add permission check in OMDBCheckpointServlet (apache#1801) HDDS-4757. Unnecessary WARNING to set OZONE_CONF_DIR (apache#1849) HDDS-4751. TestOzoneFileSystem#testTrash failed when enabledFileSystemPaths and omRatisDisabled (apache#1851) HDDS-4736. Intermittent failure in testExpiredCertificate (apache#1838) HDDS-4758. Adjust classpath of ozone version to include log4j (apache#1850) HDDS-4518. Add metrics around Trash Operations. (apache#1832) HDDS-4708. Optimization: update RetryCount less frequently (update once per ~100) (apache#1805) HDDS-4748. sonarqube issue fix - "static" members should be accessed statically (apache#1748) HDDS-2402. Adapt hadolint check to improved CI framework (apache#1778) HDDS-4698. Upgrade Java for Sonar check (apache#1800) HDDS-4739. Upgrade Ratis to 1.1.0-eb66796d-SNAPSHOT (apache#1842) HDDS-4735. Fix typo in hdds.proto (apache#1837) HDDS-4430. OM failover timeout is too short (apache#1807) HDDS-4477. Delete txnId in SCMMetadataStoreImpl may drop to 0 after SCM restart. (apache#1828) HDDS-4688. Update Hadoop version to 3.2.2 (apache#1795) HDDS-4725. Change metrics unit from nanosecond to millisecond (apache#1823) ...
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Mar 11, 2021
…mPaths and omRatisDisabled (apache#1851) (cherry picked from commit 8ec3c2e) Change-Id: I8de87b902e6984b75d5198502f05d88a31aaa903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TestOzoneFileSystem testTrash fails while setting
enableFsPathsto true. This is because of usingDeleteKeyRequestfor delete.There are 2 operations that happen when a key is moved to Trash 1. rename 2 .delete .
While Renaming a directory key, the renamedKey is stored in KeyTable with "/" (
RenameKeyRequest) irrespective ofenableFsPathsvalue but while deleting a key viaDeleteKeyRequestthe "/" is removed and a lookup is done on KeyTable which results in KEY_NOT_FOUND. UsingDeleteKeysinstead ofDeleteKeywill solve this issue as a lookup is not done on the normalised key.This PR explains why normalisation is not done while rename
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4751
How was this patch tested?
Existing Test Trash unit test.