HDDS-4081. Create ZH translation of StorageContainerManager.md in doc. #1558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainzmc
approved these changes
Nov 10, 2020
Member
captainzmc
left a comment
captainzmc
left a comment
There was a problem hiding this comment.
LGTM +1, Please trigger the CI again.
cku328
requested changes
Nov 10, 2020
Contributor
cku328
left a comment
cku328
left a comment
There was a problem hiding this comment.
I don't think it can be merged right now and I can't successfully build this commit locally.
cku328
requested changes
Nov 10, 2020
Contributor
There was a problem hiding this comment.
Thanks @yuyang733 for working on this.
I think we should ensure that some of the words are consistent with other existing documents.
Container -> 容器 ,etc.
And some suggestions on formatting.
- Insert a space around an English word.
创建Ozone集群->创建 Ozone 集群 - Parentheses should use full width characters.
(Both formats exist in existing documents, should they be unified?)
Storage Container Manager (SCM)->Storage Container Manager（SCM）
yuyang733
force-pushed
the
HDDS-4081
branch
5 times, most recently
from
ac93fc7 to
b943c91
Compare
cku328
reviewed
Nov 13, 2020
Contributor
cku328
left a comment
cku328
left a comment
There was a problem hiding this comment.
Thanks @yuyang733 for working on this.
I have some suggested changes. We can discuss it together.
Contributor
There was a problem hiding this comment.
Suggested change
| * 复制管理器的启动/停止 | |
| * 复制管理器的启动/停止 |
Incorrect indentation.
Contributor
There was a problem hiding this comment.
Suggested change
| * 管道: List/Delete/Activate/Deactivate | |
| * 管道：列出/删除/激活/停用 |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. SCM 作为块管理器，负责创建块并将其分配给相应的数据节点，客户端可以直接读写这些块； | |
| 1. SCM 作为块管理器，负责将块分配给相应的数据节点，客户端可以直接读写这些块。 |
cku328
reviewed
Nov 13, 2020
cku328
approved these changes
Nov 14, 2020
Contributor
cku328
left a comment
cku328
left a comment
There was a problem hiding this comment.
LGTM+1.
Thanks @yuyang733 for updating the patch.
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Nov 18, 2020
* master: (53 commits) HDDS-4458. Fix Max Transaction ID value in OM. (apache#1585) HDDS-4442. Disable the location information of audit logger to reduce overhead (apache#1567) HDDS-4441. Add metrics for ACL related operations.(Addendum for HA). (apache#1584) HDDS-4081. Create ZH translation of StorageContainerManager.md in doc. (apache#1558) HDDS-4080. Create ZH translation of OzoneManager.md in doc. (apache#1541) HDDS-4079. Create ZH translation of Containers.md in doc. (apache#1539) HDDS-4184. Add Features menu for Chinese document. (apache#1547) HDDS-4235. Ozone client FS path validation is not present in OFS. (apache#1582) HDDS-4338. Fix the issue that SCM web UI banner shows "HDFS SCM". (apache#1583) HDDS-4337. Implement RocksDB options cache for new datanode DB utilities. (apache#1544) HDDS-4083. Create ZH translation of Recon.md in doc (apache#1575) HDDS-4453. Replicate closed container for random selected datanodes. (apache#1574) HDDS-4408: terminate Datanode when Datanode State Machine Thread got uncaught exception. (apache#1533) HDDS-4443. Recon: Using Mysql database throws exception and fails startup (apache#1570) HDDS-4315. Use Epoch to generate unique ObjectIDs (apache#1480) HDDS-4455. Fix typo in README.md doc (apache#1578) HDDS-4441. Add metrics for ACL related operations. (apache#1571) HDDS-4437. Avoid unnecessary builder conversion in setting volume Quota/Owner request (apache#1564) HDDS-4417. Simplify Ozone client code with configuration object (apache#1542) HDDS-4363. Add metric to track the number of RocksDB open/close operations. (apache#1530) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve the ZH translation of StorageContainerManager.md in doc.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4081