Skip to content

Conversation

@vivekratnavel
Copy link
Contributor

What changes were proposed in this pull request?

Fix length of the primary key in one of the SQL tables of Recon and set auto-commit flag to default to true.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4443

How was this patch tested?

Tested the changes in a real cluster by replacing recon jar and using mariadb connector jar and jdbc URL configs for recon.

@avijayanhwx
Copy link
Contributor

Thanks for working on this @vivekratnavel.

Is it possible to add Mysql based embedded unit tests to org.apache.hadoop.ozone.recon.persistence.TestReconWithDifferentSqlDBs? Maybe something like https://stackoverflow.com/questions/6734410/is-there-a-way-to-run-mysql-in-memory-for-junit-test-cases. I am OK with adding it through a different JIRA.

@vivekratnavel
Copy link
Contributor Author

Thanks for the reviews @swagle and @avijayanhwx!

Good suggestion @avijayanhwx. I will try the embedded MySQL unit test in a different jira - https://issues.apache.org/jira/browse/HDDS-4457

@avijayanhwx avijayanhwx merged commit 7a52990 into apache:master Nov 12, 2020
errose28 added a commit to errose28/ozone that referenced this pull request Nov 18, 2020
* master: (53 commits)
  HDDS-4458. Fix Max Transaction ID value in OM. (apache#1585)
  HDDS-4442. Disable the location information of audit logger to reduce overhead (apache#1567)
  HDDS-4441. Add metrics for ACL related operations.(Addendum for HA). (apache#1584)
  HDDS-4081. Create ZH translation of StorageContainerManager.md in doc. (apache#1558)
  HDDS-4080. Create ZH translation of OzoneManager.md in doc. (apache#1541)
  HDDS-4079. Create ZH translation of Containers.md in doc. (apache#1539)
  HDDS-4184. Add Features menu for Chinese document. (apache#1547)
  HDDS-4235. Ozone client FS path validation is not present in OFS. (apache#1582)
  HDDS-4338. Fix the issue that SCM web UI banner shows "HDFS SCM". (apache#1583)
  HDDS-4337. Implement RocksDB options cache for new datanode DB utilities. (apache#1544)
  HDDS-4083. Create ZH translation of Recon.md in doc (apache#1575)
  HDDS-4453. Replicate closed container for random selected datanodes. (apache#1574)
  HDDS-4408: terminate Datanode when Datanode State Machine Thread got uncaught exception. (apache#1533)
  HDDS-4443. Recon: Using Mysql database throws exception and fails startup (apache#1570)
  HDDS-4315. Use Epoch to generate unique ObjectIDs (apache#1480)
  HDDS-4455. Fix typo in README.md doc (apache#1578)
  HDDS-4441. Add metrics for ACL related operations. (apache#1571)
  HDDS-4437. Avoid unnecessary builder conversion in setting volume Quota/Owner request (apache#1564)
  HDDS-4417. Simplify Ozone client code with configuration object (apache#1542)
  HDDS-4363. Add metric to track the number of RocksDB open/close operations. (apache#1530)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants