This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Upgrade: dmlc::optional<T> constructors and value() function #20560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mozga-intel , Thanks for submitting the PR
CI supported jobs: [sanity, edge, clang, miscellaneous, website, windows-cpu, unix-cpu, centos-cpu, centos-gpu, unix-gpu, windows-gpu] Note: |
1. Constructs an object that does contain a nullopt value.
optional(dmlc::nullopt_t) noexcept : is_none(true) {}
2. constructs an optional object that contains a value, initialized as if direct-initializing:
template <typename U, typename... Args>
3. move constructor: If other contains a value, then stored value is direct-intialized with it.
optional(optional &&other) noexcept() { }
4. move constructor: constructs the stored value with value with `other`parameter.
optional(U &&other) noexcept {
5. (...)
Upgrade: dmlc::optional<T> value
1. T &value() &
2. const T &value() const &
3. T &&value() &
4. const T && value() const &&nter the commit message for your changes. Lines starting
mozga-intel
force-pushed
the
mozga-intel/optional_dmlc_move_support
branch
2 times, most recently
from
e6a40b4
to
ed94ab4
Compare
mozga-intel
force-pushed
the
mozga-intel/optional_dmlc_move_support
branch
from
8f0bea4
to
577ce58
Compare
|
@mxnet-bot run ci [centos-gpu, windows-cpu, windows-gpu ] |
|
Jenkins CI successfully triggered : [centos-gpu, windows-cpu, windows-gpu] |
|
@mxnet-bot run ci [unix-cpu] |
|
Jenkins CI successfully triggered : [unix-cpu] |
6 tasks
…l_dmlc_move_support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The class template std::optional manages an optional contained value, i.e. a value that may or may not be present. In this pull request, a few things were implemented, such as extended series of constructors and a function of value. Mainly, this pull request is a realization of changes that have an impact on constructors,(upgrade of dmlc::optional constructors):
[Draft] PR: #658
Checklist
Essentials
Changes
Comments