This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Upgrade: dmlc::optional<T> constructors and value() function #20560
Draft
mozga-intel
wants to merge
12
commits into
apache:master
Choose a base branch
from
mozga-intel:mozga-intel/optional_dmlc_move_support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Upgrade: dmlc::optional<T> constructors and value() function #20560
mozga-intel
wants to merge
12
commits into
apache:master
from
mozga-intel:mozga-intel/optional_dmlc_move_support
Commits on Sep 1, 2021
-
Upgrade: dmlc::optional<T> ctors
1. Constructs an object that does contain a nullopt value. optional(dmlc::nullopt_t) noexcept : is_none(true) {} 2. constructs an optional object that contains a value, initialized as if direct-initializing: template <typename U, typename... Args> 3. move constructor: If other contains a value, then stored value is direct-intialized with it. optional(optional &&other) noexcept() { } 4. move constructor: constructs the stored value with value with `other`parameter. optional(U &&other) noexcept { 5. (...) Upgrade: dmlc::optional<T> value 1. T &value() & 2. const T &value() const & 3. T &&value() & 4. const T && value() const &&nter the commit message for your changes. Lines starting
Configuration menu - View commit details
-
Copy full SHA for ed94ab4 - Browse repository at this point
Copy the full SHA ed94ab4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7dc50b - Browse repository at this point
Copy the full SHA a7dc50bView commit details
Commits on Sep 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for dd36c90 - Browse repository at this point
Copy the full SHA dd36c90View commit details -
Configuration menu - View commit details
-
Copy full SHA for f00b40a - Browse repository at this point
Copy the full SHA f00b40aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dce172 - Browse repository at this point
Copy the full SHA 6dce172View commit details
Commits on Sep 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 577ce58 - Browse repository at this point
Copy the full SHA 577ce58View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1860d6 - Browse repository at this point
Copy the full SHA f1860d6View commit details
Commits on Sep 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3abb766 - Browse repository at this point
Copy the full SHA 3abb766View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16899b6 - Browse repository at this point
Copy the full SHA 16899b6View commit details
Commits on Sep 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 682a459 - Browse repository at this point
Copy the full SHA 682a459View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34d1115 - Browse repository at this point
Copy the full SHA 34d1115View commit details
Commits on Nov 18, 2021
-
Merge remote-tracking branch 'origin/master' into mozga-intel/optiona…
…l_dmlc_move_support
Configuration menu - View commit details
-
Copy full SHA for 3c2398c - Browse repository at this point
Copy the full SHA 3c2398cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.